[dpdk-stable] [PATCH v2] net/i40e: fix flow FDIR enable issue
Jeff Guo
jia.guo at intel.com
Thu May 21 16:27:28 CEST 2020
hi, zhaowei
On 5/21/2020 4:03 PM, Wei Zhao wrote:
> When we flush flow FDIR, all queues are disabled for FDIR.
> If FDIR rule is created again, then the flow list is empty,
> as it is the first time to create rule after flush fdir filter,
> so we need to enable FDIR for all queues. And also, disable FDIR
> for queues should be done in function i40e_flow_flush_fdir_filter().
>
> Fixes: 1491f63c7559 ("net/i40e: fix flush of flow director filter")
> Fixes: 6ae9b2b5e8c2 ("net/i40e: cache flow director enable value in Rx queue")
> Cc: stable at dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1 at intel.com>
>
> ---
>
> v2:
> update log info
> ---
> drivers/net/i40e/i40e_flow.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c
> index 25c77e7aa..8f8df6fae 100644
> --- a/drivers/net/i40e/i40e_flow.c
> +++ b/drivers/net/i40e/i40e_flow.c
> @@ -3462,6 +3462,10 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev *dev,
> }
> }
>
> + /* If create the first fdir rule, enable fdir check for rx queues */
> + if (TAILQ_EMPTY(&pf->fdir.fdir_list))
> + i40e_fdir_rx_proc_enable(dev, 1);
> +
Do you think it is make sense that move the configure out of the priors
condition? If so the list empty check is no need here.
if (pf->fdir.fdir_vsi == NULL) {
.....
}
ret = i40e_fdir_configure(dev);
> return 0;
> err:
> i40e_fdir_teardown(pf);
> @@ -5330,9 +5334,6 @@ i40e_flow_flush(struct rte_eth_dev *dev, struct rte_flow_error *error)
> return -rte_errno;
> }
>
> - /* Disable FDIR processing as all FDIR rules are now flushed */
> - i40e_fdir_rx_proc_enable(dev, 0);
> -
> return ret;
> }
>
> @@ -5368,6 +5369,9 @@ i40e_flow_flush_fdir_filter(struct i40e_pf *pf)
> for (pctype = I40E_FILTER_PCTYPE_NONF_IPV4_UDP;
> pctype <= I40E_FILTER_PCTYPE_L2_PAYLOAD; pctype++)
> pf->fdir.inset_flag[pctype] = 0;
> +
> + /* Disable FDIR processing as all FDIR rules are now flushed */
> + i40e_fdir_rx_proc_enable(dev, 0);
> }
>
> return ret;
More information about the stable
mailing list