[dpdk-stable] patch 'net/qede: fix link state configuration' has been queued to stable release 19.11.3

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 05/24/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 4de7d8bc2151a12801432c72df41828d3eab4138 Mon Sep 17 00:00:00 2001
From: Rasesh Mody <rmody at marvell.com>
Date: Wed, 13 May 2020 21:09:02 -0700
Subject: [PATCH] net/qede: fix link state configuration

[ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ]

Move link state enable/disable to dev_start() and dev_stop()
respectively. This will ensure when devices are stopped,
link status will be appropriately shown as down.

Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")

Signed-off-by: Shahed Shaikh <shshaikh at marvell.com>
Signed-off-by: Rasesh Mody <rmody at marvell.com>
Signed-off-by: Igor Russkikh <irusskikh at marvell.com>
---
 drivers/net/qede/qede_ethdev.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index c7a4c031b7..4b3f506506 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -1076,6 +1076,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
 	if (qede_activate_vport(eth_dev, true))
 		goto err;
 
+	/* Bring-up the link */
+	qede_dev_set_link_state(eth_dev, true);
+
 	/* Update link status */
 	qede_link_update(eth_dev, 0);
 
@@ -1097,6 +1100,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
 
 	PMD_INIT_FUNC_TRACE(edev);
 
+	/* Bring the link down */
+	qede_dev_set_link_state(eth_dev, false);
+
+	/* Update link status */
+	qede_link_update(eth_dev, 0);
+
 	/* Disable vport */
 	if (qede_activate_vport(eth_dev, false))
 		return;
@@ -1481,8 +1490,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
 	eth_dev->data->nb_rx_queues = 0;
 	eth_dev->data->nb_tx_queues = 0;
 
-	/* Bring the link down */
-	qede_dev_set_link_state(eth_dev, false);
 	qdev->ops->common->slowpath_stop(edev);
 	qdev->ops->common->remove(edev);
 	rte_intr_disable(&pci_dev->intr_handle);
@@ -2605,9 +2612,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
 
 	eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;
 
-	/* Bring-up the link */
-	qede_dev_set_link_state(eth_dev, true);
-
 	adapter->num_tx_queues = 0;
 	adapter->num_rx_queues = 0;
 	SLIST_INIT(&adapter->arfs_info.arfs_list_head);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-22 10:37:39.763972707 +0100
+++ 0014-net-qede-fix-link-state-configuration.patch	2020-05-22 10:37:39.088411997 +0100
@@ -1,14 +1,15 @@
-From d789705873d47d70a3ba0a6a4dfb83fb629d3464 Mon Sep 17 00:00:00 2001
+From 4de7d8bc2151a12801432c72df41828d3eab4138 Mon Sep 17 00:00:00 2001
 From: Rasesh Mody <rmody at marvell.com>
 Date: Wed, 13 May 2020 21:09:02 -0700
 Subject: [PATCH] net/qede: fix link state configuration
 
+[ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ]
+
 Move link state enable/disable to dev_start() and dev_stop()
 respectively. This will ensure when devices are stopped,
 link status will be appropriately shown as down.
 
 Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence")
-Cc: stable at dpdk.org
 
 Signed-off-by: Shahed Shaikh <shshaikh at marvell.com>
 Signed-off-by: Rasesh Mody <rmody at marvell.com>
@@ -18,10 +19,10 @@
  1 file changed, 9 insertions(+), 5 deletions(-)
 
 diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
-index e71fa1e6a7..0b1fca9aca 100644
+index c7a4c031b7..4b3f506506 100644
 --- a/drivers/net/qede/qede_ethdev.c
 +++ b/drivers/net/qede/qede_ethdev.c
-@@ -1144,6 +1144,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
+@@ -1076,6 +1076,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev)
  	if (qede_activate_vport(eth_dev, true))
  		goto err;
  
@@ -31,7 +32,7 @@
  	/* Update link status */
  	qede_link_update(eth_dev, 0);
  
-@@ -1166,6 +1169,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
+@@ -1097,6 +1100,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev)
  
  	PMD_INIT_FUNC_TRACE(edev);
  
@@ -44,7 +45,7 @@
  	/* Disable vport */
  	if (qede_activate_vport(eth_dev, false))
  		return;
-@@ -1550,8 +1559,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
+@@ -1481,8 +1490,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev)
  	eth_dev->data->nb_rx_queues = 0;
  	eth_dev->data->nb_tx_queues = 0;
  
@@ -53,7 +54,7 @@
  	qdev->ops->common->slowpath_stop(edev);
  	qdev->ops->common->remove(edev);
  	rte_intr_disable(&pci_dev->intr_handle);
-@@ -2672,9 +2679,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
+@@ -2605,9 +2612,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf)
  
  	eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;