[dpdk-stable] [dpdk-dev] [PATCH] bus/vmbus: fix wrong allocation for device.name

[Stephen Hemminger]

On Thu, 28 May 2020 20:03:07 +0800
wangyunjian <wangyunjian at huawei.com> wrote:

> From: Yunjian Wang <wangyunjian at huawei.com>
> 
> We do not need and should not allocate memory for device.name.
> The device.name should be set point to the devargs->name.
> 
> Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
> Cc: stable at dpdk.org
> 
> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
> ---
>  drivers/bus/vmbus/linux/vmbus_bus.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/bus/vmbus/linux/vmbus_bus.c b/drivers/bus/vmbus/linux/vmbus_bus.c
> index 3c924ee..31d0dd3 100644
> --- a/drivers/bus/vmbus/linux/vmbus_bus.c
> +++ b/drivers/bus/vmbus/linux/vmbus_bus.c
> @@ -242,9 +242,6 @@
>  		return -1;
>  
>  	dev->device.bus = &rte_vmbus_bus.bus;
> -	dev->device.name = strdup(name);
> -	if (!dev->device.name)
> -		goto error;
>  
>  	/* sysfs base directory
>  	 *   /sys/bus/vmbus/devices/7a08391f-f5a0-4ac0-9802-d13fd964f8df
> @@ -296,6 +293,7 @@
>  	}
>  
>  	dev->device.devargs = vmbus_devargs_lookup(dev);
> +	dev->device.name = dev->device.devargs->name;
>  
>  	/* device is valid, add in list (sorted) */
>  	VMBUS_LOG(DEBUG, "Adding vmbus device %s", name);

This doesn't seem right. devargs is not filled in unless devargs is used.