[dpdk-stable] patch 'test/crypto: fix flag check' has been queued to LTS release 18.11.9

Kevin Traynor ktraynor at redhat.com
Thu May 28 18:22:25 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/03/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/d76d109d743b6f68511c3ec51e43ed024bb64127

Thanks.

Kevin.

---
>From d76d109d743b6f68511c3ec51e43ed024bb64127 Mon Sep 17 00:00:00 2001
From: Pablo de Lara <pablo.de.lara.guarch at intel.com>
Date: Thu, 16 Apr 2020 18:12:46 +0100
Subject: [PATCH] test/crypto: fix flag check

[ upstream commit 042bb5654404643afcebef194d23f559606665ef ]

An incorrect flag check was done, using "&&" instead of "&".

Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag")

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
Acked-by: Fiona Trahe <fiona.trahe at intel.com>
---
 test/test/test_cryptodev_blockcipher.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c
index 4f1298ea21..660d5a7682 100644
--- a/test/test/test_cryptodev_blockcipher.c
+++ b/test/test/test_cryptodev_blockcipher.c
@@ -86,5 +86,5 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
 		uint64_t oop_flag = RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT;
 
-		if (t->feature_mask && BLOCKCIPHER_TEST_FEATURE_OOP) {
+		if (t->feature_mask & BLOCKCIPHER_TEST_FEATURE_OOP) {
 			if (!(feat_flags & oop_flag)) {
 				printf("Device doesn't support out-of-place "
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-28 17:13:01.119621534 +0100
+++ 0038-test-crypto-fix-flag-check.patch	2020-05-28 17:12:59.106556287 +0100
@@ -1 +1 @@
-From 042bb5654404643afcebef194d23f559606665ef Mon Sep 17 00:00:00 2001
+From d76d109d743b6f68511c3ec51e43ed024bb64127 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 042bb5654404643afcebef194d23f559606665ef ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -14 +15 @@
- app/test/test_cryptodev_blockcipher.c | 2 +-
+ test/test/test_cryptodev_blockcipher.c | 2 +-
@@ -17,5 +18,5 @@
-diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
-index 2ff7fc91ba..4973c74a92 100644
---- a/app/test/test_cryptodev_blockcipher.c
-+++ b/app/test/test_cryptodev_blockcipher.c
-@@ -94,5 +94,5 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,
+diff --git a/test/test/test_cryptodev_blockcipher.c b/test/test/test_cryptodev_blockcipher.c
+index 4f1298ea21..660d5a7682 100644
+--- a/test/test/test_cryptodev_blockcipher.c
++++ b/test/test/test_cryptodev_blockcipher.c
+@@ -86,5 +86,5 @@ test_blockcipher_one_case(const struct blockcipher_test_case *t,



More information about the stable mailing list