[dpdk-stable] patch 'net/netvsc: remove process event optimization' has been queued to LTS release 18.11.9

Kevin Traynor ktraynor at redhat.com
Thu May 28 18:22:45 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/03/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/30779c9fd3d5e7052fd60d5829c052fa1d1b0b40

Thanks.

Kevin.

---
>From 30779c9fd3d5e7052fd60d5829c052fa1d1b0b40 Mon Sep 17 00:00:00 2001
From: Stephen Hemminger <stephen at networkplumber.org>
Date: Tue, 31 Mar 2020 10:14:01 -0700
Subject: [PATCH] net/netvsc: remove process event optimization

[ upstream commit dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 ]

Remove unlocked check for data in receive ring.
This check is not safe because of missing barriers etc.

Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")

Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
---
 drivers/net/netvsc/hn_rxtx.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
index 06408250a8..1fb8dec9a9 100644
--- a/drivers/net/netvsc/hn_rxtx.c
+++ b/drivers/net/netvsc/hn_rxtx.c
@@ -954,8 +954,4 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id,
 	rxq = queue_id == 0 ? hv->primary : dev->data->rx_queues[queue_id];
 
-	/* If no pending data then nothing to do */
-	if (rte_vmbus_chan_rx_empty(rxq->chan))
-		return 0;
-
 	/*
 	 * Since channel is shared between Rx and TX queue need to have a lock
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-28 17:13:02.119726431 +0100
+++ 0058-net-netvsc-remove-process-event-optimization.patch	2020-05-28 17:12:59.133555676 +0100
@@ -1 +1 @@
-From dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 Mon Sep 17 00:00:00 2001
+From 30779c9fd3d5e7052fd60d5829c052fa1d1b0b40 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit dfd3f0fce8bd64182b984b4a9226f2d23c44b2d5 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 32c03e3da0..e8df846042 100644
+index 06408250a8..1fb8dec9a9 100644
@@ -21 +22 @@
-@@ -970,8 +970,4 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id,
+@@ -954,8 +954,4 @@ uint32_t hn_process_events(struct hn_data *hv, uint16_t queue_id,



More information about the stable mailing list