[dpdk-stable] patch 'net/bnxt: fix VLAN add when port is stopped' has been queued to LTS release 18.11.9

Kevin Traynor ktraynor at redhat.com
Thu May 28 18:23:14 CEST 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.9

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 06/03/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/56090ed8eab43f2a4319d098aa89baec60f60817

Thanks.

Kevin.

---
>From 56090ed8eab43f2a4319d098aa89baec60f60817 Mon Sep 17 00:00:00 2001
From: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Date: Tue, 21 Apr 2020 14:33:49 -0700
Subject: [PATCH] net/bnxt: fix VLAN add when port is stopped

[ upstream commit 8b60154d4b8a413eec43aafce1b4341dd575d4c3 ]

Driver destroys the vnic when the port is brought down.
When user tries to add a vlan when port is stopped, driver
issues HWRM command to FW with invalid vnic_id and it fails.

Fixed to return an error while setting vlan when port is
not started.

Fixes: b4e190d55c25 ("net/bnxt: fix MAC/VLAN filter allocation")

Signed-off-by: Kalesh AP <kalesh-anakkur.purayil at broadcom.com>
Reviewed-by: Venkat Duvvuru <venkatkumar.duvvuru at broadcom.com>
Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
---
 drivers/net/bnxt/bnxt_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 90139bc837..2dbfd11cd7 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1419,4 +1419,9 @@ static int bnxt_vlan_filter_set_op(struct rte_eth_dev *eth_dev,
 	struct bnxt *bp = eth_dev->data->dev_private;
 
+	if (!eth_dev->data->dev_started) {
+		PMD_DRV_LOG(ERR, "port must be started before setting vlan\n");
+		return -EINVAL;
+	}
+
 	/* These operations apply to ALL existing MAC/VLAN filters */
 	if (on)
-- 
2.21.3

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-05-28 17:13:03.615603625 +0100
+++ 0087-net-bnxt-fix-VLAN-add-when-port-is-stopped.patch	2020-05-28 17:12:59.181554590 +0100
@@ -1 +1 @@
-From 8b60154d4b8a413eec43aafce1b4341dd575d4c3 Mon Sep 17 00:00:00 2001
+From 56090ed8eab43f2a4319d098aa89baec60f60817 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8b60154d4b8a413eec43aafce1b4341dd575d4c3 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -24 +25 @@
-index 206111db5b..589190b372 100644
+index 90139bc837..2dbfd11cd7 100644
@@ -27,2 +28,2 @@
-@@ -2083,4 +2083,9 @@ static int bnxt_vlan_filter_set_op(struct rte_eth_dev *eth_dev,
- 		return rc;
+@@ -1419,4 +1419,9 @@ static int bnxt_vlan_filter_set_op(struct rte_eth_dev *eth_dev,
+ 	struct bnxt *bp = eth_dev->data->dev_private;



More information about the stable mailing list