[dpdk-stable] patch 'raw/skeleton: allow closing already closed device' has been queued to LTS release 18.11.11

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/10/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/21e209841c900a4ca532830df84cb357a152d582

Thanks.

Kevin.

---
>From 21e209841c900a4ca532830df84cb357a152d582 Mon Sep 17 00:00:00 2001
From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Date: Mon, 21 Sep 2020 23:44:20 +0200
Subject: [PATCH] raw/skeleton: allow closing already closed device

[ upstream commit e640362b34e868b82bfb047761e05056ba77e58e ]

This patch return OK code (0) from skeleton_rawdev_close function
if firmware is in SKELETON_FW_READY state. Formerly it returned
-EINVAL error code.

Returning an error here is troublesome as it disallows proper release
of the rawdev. The rte_rawdev_pmd_release function from librte_rawdev
library calls drivers' rawdev_close handler and continues execution
only in case of errorless call.
(see lib/librte_rawdev/rte_rawdev.c:540)

The SKELETON_FW_READY state is reached after creation, reset, unload
or close of the device. The device should be ok to be released in
such situations.

To reproduce issue fixed by this patch, call rawdev_autotest
from dpdk-test app for few times. As the device is not properly
released, the next calls will fail.

Fixes: 61c592a8d035 ("raw/skeleton: introduce skeleton rawdev driver")

Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
---
 drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
index 6eabd97ee2..78815b056c 100644
--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
@@ -190,7 +190,9 @@ static int skeleton_rawdev_close(struct rte_rawdev *dev)
 		break;
 	case SKELETON_FW_READY:
+		SKELETON_PMD_DEBUG("Device already in stopped state");
+		break;
 	case SKELETON_FW_ERROR:
 	default:
-		SKELETON_PMD_DEBUG("Device already in stopped state");
+		SKELETON_PMD_DEBUG("Device in impossible state");
 		ret = -EINVAL;
 		break;
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-05 12:38:55.124556575 +0000
+++ 0046-raw-skeleton-allow-closing-already-closed-device.patch	2020-11-05 12:38:54.245896024 +0000
@@ -1 +1 @@
-From e640362b34e868b82bfb047761e05056ba77e58e Mon Sep 17 00:00:00 2001
+From 21e209841c900a4ca532830df84cb357a152d582 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e640362b34e868b82bfb047761e05056ba77e58e ]
+
@@ -25 +26,0 @@
-Cc: stable at dpdk.org
@@ -29 +30 @@
- drivers/raw/skeleton/skeleton_rawdev.c | 4 +++-
+ drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 4 +++-
@@ -32,5 +33,5 @@
-diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c
-index f8b47a391a..aa3beaad18 100644
---- a/drivers/raw/skeleton/skeleton_rawdev.c
-+++ b/drivers/raw/skeleton/skeleton_rawdev.c
-@@ -191,7 +191,9 @@ static int skeleton_rawdev_close(struct rte_rawdev *dev)
+diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
+index 6eabd97ee2..78815b056c 100644
+--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
++++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c
+@@ -190,7 +190,9 @@ static int skeleton_rawdev_close(struct rte_rawdev *dev)