[dpdk-stable] patch 'net/qede: fix getting link details' has been queued to LTS release 18.11.11

Kevin Traynor ktraynor at redhat.com
Thu Nov 5 13:39:59 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/10/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/b4fa19fc18cd83aad28df7bb973c28a4918ee694

Thanks.

Kevin.

---
>From b4fa19fc18cd83aad28df7bb973c28a4918ee694 Mon Sep 17 00:00:00 2001
From: Rasesh Mody <rmody at marvell.com>
Date: Fri, 2 Oct 2020 12:59:45 -0700
Subject: [PATCH] net/qede: fix getting link details

[ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ]

This patch fixes get current link details, without this change the link
details can be inaccurate if proper lock is not acquired.

Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")

Reported-by: Ferruh Yigit <ferruh.yigit at intel.com>
Signed-off-by: Rasesh Mody <rmody at marvell.com>
Signed-off-by: Igor Russkikh <irusskikh at marvell.com>
---
 drivers/net/qede/qede_main.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index 0ac4300465..c124b2532b 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -576,11 +576,10 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
 	if (IS_PF(edev)) {
 		ptt = ecore_ptt_acquire(hwfn);
-		if (!ptt)
-			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
-
+		if (ptt) {
 			qed_fill_link(hwfn, ptt, if_link);
-
-		if (ptt)
 			ecore_ptt_release(hwfn, ptt);
+		} else {
+			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
+		}
 	} else {
 		qed_fill_link(hwfn, NULL, if_link);
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-05 12:38:55.230290183 +0000
+++ 0052-net-qede-fix-getting-link-details.patch	2020-11-05 12:38:54.251896028 +0000
@@ -1 +1 @@
-From effb1d0b9527815a7cd5422bce5defbc0884cea0 Mon Sep 17 00:00:00 2001
+From b4fa19fc18cd83aad28df7bb973c28a4918ee694 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ]
+
@@ -10 +11,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 0d3cea6e42..caa9d1d4f6 100644
+index 0ac4300465..c124b2532b 100644
@@ -23 +24 @@
-@@ -588,11 +588,10 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
+@@ -576,11 +576,10 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)



More information about the stable mailing list