[dpdk-stable] patch 'test/crypto: fix stats test' has been queued to LTS release 18.11.11

Kevin Traynor ktraynor at redhat.com
Thu Nov 5 13:40:11 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/10/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/52d2001b4edc3c92018349718f961a0c6168bcb4

Thanks.

Kevin.

---
>From 52d2001b4edc3c92018349718f961a0c6168bcb4 Mon Sep 17 00:00:00 2001
From: Ruifeng Wang <ruifeng.wang at arm.com>
Date: Mon, 31 Aug 2020 16:51:43 +0800
Subject: [PATCH] test/crypto: fix stats test

[ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ]

ut_setup / ut_teardown are invoked for each test case by test framework.
The call inside test_stats is unnecessary and even incorrect.
This caused double free of objects such as crypto operation structure.
Trapped the issue when RTE_LIBRTE_MEMPOOL_DEBUG was enabled.
Fix issue by removing ut_setup / ut_teardown from test case implementation.

Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests")

Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
Tested-by: Adam Dybkowski <adamx.dybkowski at intel.com>
---
 test/test/test_cryptodev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
index 210507eb8a..021fc099b3 100644
--- a/test/test/test_cryptodev.c
+++ b/test/test/test_cryptodev.c
@@ -6509,7 +6509,5 @@ test_stats(void)
 
 	/* Test expected values */
-	ut_setup();
 	test_AES_CBC_HMAC_SHA1_encrypt_digest();
-	ut_teardown();
 	TEST_ASSERT_SUCCESS(rte_cryptodev_stats_get(ts_params->valid_devs[0],
 			&stats),
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-05 12:38:55.737527335 +0000
+++ 0064-test-crypto-fix-stats-test.patch	2020-11-05 12:38:54.275896047 +0000
@@ -1 +1 @@
-From b450503612eebc59de96aa3f20ec5ea0e3ceb400 Mon Sep 17 00:00:00 2001
+From 52d2001b4edc3c92018349718f961a0c6168bcb4 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit b450503612eebc59de96aa3f20ec5ea0e3ceb400 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
- app/test/test_cryptodev.c | 2 --
+ test/test/test_cryptodev.c | 2 --
@@ -21,5 +22,5 @@
-diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
-index 704aa7c414..d702cb91a3 100644
---- a/app/test/test_cryptodev.c
-+++ b/app/test/test_cryptodev.c
-@@ -9327,7 +9327,5 @@ test_stats(void)
+diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c
+index 210507eb8a..021fc099b3 100644
+--- a/test/test/test_cryptodev.c
++++ b/test/test/test_cryptodev.c
+@@ -6509,7 +6509,5 @@ test_stats(void)



More information about the stable mailing list