[dpdk-stable] patch 'raw/ifpga/base: fix return of IRQ unregister' has been queued to stable release 19.11.6

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/11/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/0911adf9dbab697f834efcdb0794b6cbe5919095

Thanks.

Luca Boccassi

---
>From 0911adf9dbab697f834efcdb0794b6cbe5919095 Mon Sep 17 00:00:00 2001
From: Wei Huang <wei.huang at intel.com>
Date: Fri, 23 Oct 2020 04:59:57 -0400
Subject: [PATCH] raw/ifpga/base: fix return of IRQ unregister

[ upstream commit 93824cadd8f430d14c91e48146a99f90e8d31f28 ]

Since 'rte_intr_callback_unregister()' can return positive
value as success, but 'ifpga_rawdev_destroy()' handle it as
an error.

Instead, only negative return is treated as failure.

Fixes: e0a1aafe2af9 ("raw/ifpga: introduce IRQ functions")

Signed-off-by: Wei Huang <wei.huang at intel.com>
Signed-off-by: Tianfei Zhang <tianfei.zhang at intel.com>
Acked-by: Rosen Xu <rosen.xu at intel.com>
---
 drivers/raw/ifpga/ifpga_rawdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c
index fee24a98e1..7bfdde650d 100644
--- a/drivers/raw/ifpga/ifpga_rawdev.c
+++ b/drivers/raw/ifpga/ifpga_rawdev.c
@@ -1563,7 +1563,7 @@ ifpga_rawdev_destroy(struct rte_pci_device *pci_dev)
 		return -ENODEV;
 
 	if (ifpga_unregister_msix_irq(IFPGA_FME_IRQ, 0,
-				fme_interrupt_handler, mgr))
+				fme_interrupt_handler, mgr) < 0)
 		return -EINVAL;
 
 	opae_adapter_data_free(adapter->data);
-- 
2.27.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-09 18:40:13.174904648 +0000
+++ 0051-raw-ifpga-base-fix-return-of-IRQ-unregister.patch	2020-11-09 18:40:11.179312029 +0000
@@ -1 +1 @@
-From 93824cadd8f430d14c91e48146a99f90e8d31f28 Mon Sep 17 00:00:00 2001
+From 0911adf9dbab697f834efcdb0794b6cbe5919095 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 93824cadd8f430d14c91e48146a99f90e8d31f28 ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index 6319988066..fdeb713ff6 100644
+index fee24a98e1..7bfdde650d 100644
@@ -26 +27 @@
-@@ -1559,7 +1559,7 @@ ifpga_rawdev_destroy(struct rte_pci_device *pci_dev)
+@@ -1563,7 +1563,7 @@ ifpga_rawdev_destroy(struct rte_pci_device *pci_dev)