[dpdk-stable] [dpdk-dev] [PATCH 1/4] event/dlb: fix memory overrun Coverity warning

McDaniel, Timothy timothy.mcdaniel at intel.com
Tue Nov 10 16:44:01 CET 2020



> -----Original Message-----
> From: Jerin Jacob <jerinjacobk at gmail.com>
> Sent: Tuesday, November 10, 2020 9:36 AM
> To: McDaniel, Timothy <timothy.mcdaniel at intel.com>
> Cc: Eads, Gage <gage.eads at intel.com>; dpdk-dev <dev at dpdk.org>; Carrillo,
> Erik G <erik.g.carrillo at intel.com>; Van Haaren, Harry
> <harry.van.haaren at intel.com>; Jerin Jacob <jerinj at marvell.com>;
> john.mcnamara at dpdk.org; dpdk stable <stable at dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH 1/4] event/dlb: fix memory overrun Coverity
> warning
> 
> On Fri, Nov 6, 2020 at 2:51 AM Timothy McDaniel
> <timothy.mcdaniel at intel.com> wrote:
> >
> > Fix memory corruption bug caused by passing address of a 16b value,
> > instead of address of a 32b value.
> >
> > Fixes: 1998008 ("event/dlb: add eventdev probe")
> > Coverity issue: 363715
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: Timothy McDaniel <timothy.mcdaniel at intel.com>
> 
> Series applied to dpdk-next-eventdev/for-main. Thanks.
> 

Thank you, Jerin.

> 
> > ---
> >  drivers/event/dlb/pf/dlb_main.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/event/dlb/pf/dlb_main.c b/drivers/event/dlb/pf/dlb_main.c
> > index 87ab8dd..17e671e 100644
> > --- a/drivers/event/dlb/pf/dlb_main.c
> > +++ b/drivers/event/dlb/pf/dlb_main.c
> > @@ -250,13 +250,13 @@ dlb_pf_reset(struct dlb_dev *dlb_dev)
> >  {
> >         int msix_cap_offset, err_cap_offset, acs_cap_offset, wait_count;
> >         uint16_t dev_ctl_word, dev_ctl2_word, lnk_word, lnk_word2;
> > -       uint16_t rt_ctl_word, pri_reqs_dword,  pri_ctrl_word;
> > +       uint16_t rt_ctl_word, pri_ctrl_word;
> >         struct rte_pci_device *pdev = dlb_dev->pdev;
> >         uint16_t devsta_busy_word, devctl_word;
> >         int pcie_cap_offset, pri_cap_offset;
> >         uint16_t slt_word, slt_word2, cmd;
> >         int ret = 0, i = 0;
> > -       uint32_t dword[16];
> > +       uint32_t dword[16], pri_reqs_dword;
> >         off_t off;
> >
> >         /* Save PCI config state */
> > --
> > 2.6.4
> >


More information about the stable mailing list