[dpdk-stable] patch 'app/testpmd: fix name of bitrate library in meson build' has been queued to LTS release 18.11.11

Luca Boccassi bluca at debian.org
Wed Nov 11 12:51:53 CET 2020


On Wed, 2020-11-11 at 10:50 +0000, Kevin Traynor wrote:
> On 11/11/2020 10:44, Kevin Traynor wrote:
> > On 05/11/2020 13:22, David Marchand wrote:
> > > On Thu, Nov 5, 2020 at 1:41 PM Kevin Traynor <ktraynor at redhat.com> wrote:
> > > > From 1bde6247b23c54adb47fa48a5373270ca05a32b4 Mon Sep 17 00:00:00 2001
> > > > From: Bruce Richardson <bruce.richardson at intel.com>
> > > > Date: Wed, 2 Sep 2020 17:24:27 +0100
> > > > Subject: [PATCH] app/testpmd: fix name of bitrate library in meson build
> > > > 
> > > > [ upstream commit 54f89e3df4b16e9079c9d343870d16757429b68b ]
> > > > 
> > > > The bitrate library in DPDK is actually in a "bitratestats" directory,
> > > > so that is used by meson for the macro and library name.
> > > > Therefore, we need to update references to RTE_LIBRTE_BITRATE to
> > > > RTE_LIBRTE_BITRATESTATS in testpmd to have it found. Rather than
> > > > supporting both defines, since make is being removed, we can just
> > > > replace all instances of the former define with the latter.
> > > > 
> > > > To ensure testpmd links ok when this is done, we also need to add
> > > > bitratestats to the list of library dependencies.
> > > 
> > > This backport will fix meson builds, but it will drop bitratestats
> > > support in testpmd built with make.
> > > 
> > > 
> > 
> > Thanks David. That would be a user visible regression, so we can't do
> > that. I will drop the patch for now and we can discuss after 20.11 when
> > everyone is less busy.
> > 
> 
> +Luca, fyi, this patch is in 19.11 tree.

Thanks for the heads-up, I'll revert it for now.

-- 
Kind regards,
Luca Boccassi


More information about the stable mailing list