[dpdk-stable] patch 'examples/kni: fix build with pkg-config' has been queued to stable release 19.11.6

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Nov 17 12:14:11 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/19/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/8a08b390f358454f343774222e34d38350030699

Thanks.

Luca Boccassi

---
>From 8a08b390f358454f343774222e34d38350030699 Mon Sep 17 00:00:00 2001
From: David Marchand <david.marchand at redhat.com>
Date: Sat, 14 Nov 2020 10:05:25 +0100
Subject: [PATCH] examples/kni: fix build with pkg-config

[ upstream commit 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 ]

rm -f build/kni build/kni-static build/kni-shared
test -d build && rmdir -p build || true
[...]
/usr/bin/ld: /tmp/cc72ssnK.o: undefined reference to symbol
'pthread_join@@GLIBC_2.2.5'

This example explicitly call pthread API and should be linked against
the pthread library.

Fixes: 724beb913b44 ("examples/kni: monitor and update link state continually")

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 examples/kni/Makefile | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/examples/kni/Makefile b/examples/kni/Makefile
index 8fcb67c619..10b42891da 100644
--- a/examples/kni/Makefile
+++ b/examples/kni/Makefile
@@ -25,6 +25,8 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
 LDFLAGS_SHARED = $(shell $(PKGCONF) --libs libdpdk)
 LDFLAGS_STATIC = $(shell $(PKGCONF) --static --libs libdpdk)
 
+LDFLAGS += -pthread
+
 build/$(APP)-shared: $(SRCS-y) Makefile $(PC_FILE) | build
 	$(CC) $(CFLAGS) $(SRCS-y) -o $@ $(LDFLAGS) $(LDFLAGS_SHARED)
 
-- 
2.27.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-17 11:13:14.542381978 +0000
+++ 0037-examples-kni-fix-build-with-pkg-config.patch	2020-11-17 11:13:12.953117254 +0000
@@ -1 +1 @@
-From 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 Mon Sep 17 00:00:00 2001
+From 8a08b390f358454f343774222e34d38350030699 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 58a0648bd33c3cb7ff6e746c639e0613fda4b9b0 ]
+
@@ -16 +17,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index fa9fa85319..bbf3bcae12 100644
+index 8fcb67c619..10b42891da 100644
@@ -28 +29 @@
-@@ -27,6 +27,8 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API
+@@ -25,6 +25,8 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API


More information about the stable mailing list