[dpdk-stable] patch 'distributor: fix scalar matching' has been queued to LTS release 18.11.11

Kevin Traynor ktraynor at redhat.com
Wed Nov 18 17:35:15 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/24/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/faf47ff9cdad6bfb0a4863ec184ec32d8656ccd1

Thanks.

Kevin.

---
>From faf47ff9cdad6bfb0a4863ec184ec32d8656ccd1 Mon Sep 17 00:00:00 2001
From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Date: Sat, 17 Oct 2020 05:06:56 +0200
Subject: [PATCH] distributor: fix scalar matching

[ upstream commit 626ceefbf4e1786ded4fed6a4987e3f1d370e9c0 ]

Fix improper indexes while comparing tags.
In the find_match_scalar() function:
* j iterates over flow tags of following packets;
* w iterates over backlog or in flight tags positions.

Fixes: 775003ad2f96 ("distributor: add new burst-capable library")

Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Acked-by: David Hunt <david.hunt at intel.com>
---
 lib/librte_distributor/rte_distributor.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_distributor/rte_distributor.c b/lib/librte_distributor/rte_distributor.c
index 873ca290dd..a417e06d78 100644
--- a/lib/librte_distributor/rte_distributor.c
+++ b/lib/librte_distributor/rte_distributor.c
@@ -278,5 +278,5 @@ find_match_scalar(struct rte_distributor *d,
 		for (j = 0; j < RTE_DIST_BURST_SIZE ; j++)
 			for (w = 0; w < RTE_DIST_BURST_SIZE; w++)
-				if (d->in_flight_tags[i][j] == data_ptr[w]) {
+				if (d->in_flight_tags[i][w] == data_ptr[j]) {
 					output_ptr[j] = i+1;
 					break;
@@ -284,5 +284,5 @@ find_match_scalar(struct rte_distributor *d,
 		for (j = 0; j < RTE_DIST_BURST_SIZE; j++)
 			for (w = 0; w < RTE_DIST_BURST_SIZE; w++)
-				if (bl->tags[j] == data_ptr[w]) {
+				if (bl->tags[w] == data_ptr[j]) {
 					output_ptr[j] = i+1;
 					break;
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-18 16:33:38.506137064 +0000
+++ 0029-distributor-fix-scalar-matching.patch	2020-11-18 16:33:37.932215064 +0000
@@ -1 +1 @@
-From 626ceefbf4e1786ded4fed6a4987e3f1d370e9c0 Mon Sep 17 00:00:00 2001
+From faf47ff9cdad6bfb0a4863ec184ec32d8656ccd1 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 626ceefbf4e1786ded4fed6a4987e3f1d370e9c0 ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -21 +22 @@
-index 6e3eae58f8..9fea3f69ab 100644
+index 873ca290dd..a417e06d78 100644
@@ -24 +25 @@
-@@ -260,5 +260,5 @@ find_match_scalar(struct rte_distributor *d,
+@@ -278,5 +278,5 @@ find_match_scalar(struct rte_distributor *d,
@@ -31 +32 @@
-@@ -266,5 +266,5 @@ find_match_scalar(struct rte_distributor *d,
+@@ -284,5 +284,5 @@ find_match_scalar(struct rte_distributor *d,



More information about the stable mailing list