[dpdk-stable] patch 'test/distributor: fix quitting workers in burst mode' has been queued to LTS release 18.11.11

Kevin Traynor ktraynor at redhat.com
Wed Nov 18 17:35:18 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/24/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/159e26b128ea69ca55e387ef541e70f4c261924a

Thanks.

Kevin.

---
>From 159e26b128ea69ca55e387ef541e70f4c261924a Mon Sep 17 00:00:00 2001
From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Date: Sat, 17 Oct 2020 05:07:01 +0200
Subject: [PATCH] test/distributor: fix quitting workers in burst mode

[ upstream commit f72bff0ec2723b7d7bfc9c655419030b1c8fffad ]

Sending number of packets equal to number of workers isn't enough
to stop all workers in burst version of distributor as more than
one packet can be matched and consumed by a single worker. This way
some of workers might not be awaken from rte_distributor_get_pkt().

This patch fixes it by sending packets one by one. Each sent packet
causes exactly one worker to quit.

Fixes: 775003ad2f96 ("distributor: add new burst-capable library")

Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
---
 test/test/test_distributor.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c
index 459f75b96a..e00966366d 100644
--- a/test/test/test_distributor.c
+++ b/test/test/test_distributor.c
@@ -612,7 +612,8 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)
 	zero_quit = 0;
 	quit = 1;
-	for (i = 0; i < num_workers; i++)
+	for (i = 0; i < num_workers; i++) {
 		bufs[i]->hash.usr = i << 1;
-	rte_distributor_process(d, bufs, num_workers);
+		rte_distributor_process(d, &bufs[i], 1);
+	}
 
 	rte_distributor_process(d, NULL, 0);
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-18 16:33:38.555745692 +0000
+++ 0032-test-distributor-fix-quitting-workers-in-burst-mode.patch	2020-11-18 16:33:37.934215065 +0000
@@ -1 +1 @@
-From f72bff0ec2723b7d7bfc9c655419030b1c8fffad Mon Sep 17 00:00:00 2001
+From 159e26b128ea69ca55e387ef541e70f4c261924a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit f72bff0ec2723b7d7bfc9c655419030b1c8fffad ]
+
@@ -15 +16,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
- app/test/test_distributor.c | 5 +++--
+ test/test/test_distributor.c | 5 +++--
@@ -23,5 +24,5 @@
-diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
-index a4af0a39c6..e0cb698e1c 100644
---- a/app/test/test_distributor.c
-+++ b/app/test/test_distributor.c
-@@ -770,7 +770,8 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)
+diff --git a/test/test/test_distributor.c b/test/test/test_distributor.c
+index 459f75b96a..e00966366d 100644
+--- a/test/test/test_distributor.c
++++ b/test/test/test_distributor.c
+@@ -612,7 +612,8 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)



More information about the stable mailing list