[dpdk-stable] patch 'vhost: validate index in guest notification API' has been queued to LTS release 18.11.11

[Kevin Traynor]

Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/24/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/c1e34850b7c10c4c8e22f52bd9f73e7184e939ea

Thanks.

Kevin.

---
>From c1e34850b7c10c4c8e22f52bd9f73e7184e939ea Mon Sep 17 00:00:00 2001
From: Maxime Coquelin <maxime.coquelin at redhat.com>
Date: Mon, 19 Oct 2020 19:34:11 +0200
Subject: [PATCH] vhost: validate index in guest notification API

[ upstream commit 366374054b656e049188216e2fa44831749c2a21 ]

This patch validates the queue index parameter, in order
to ensure neither out-of-bound accesses nor NULL pointer
dereferencing happen.

Fixes: 9eed6bfd2efb ("vhost: allow to enable or disable features")

Signed-off-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Reviewed-by: Chenbo Xia <chenbo.xia at intel.com>
---
 lib/librte_vhost/vhost.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c
index 2fd454441a..61754833c2 100644
--- a/lib/librte_vhost/vhost.c
+++ b/lib/librte_vhost/vhost.c
@@ -984,5 +984,10 @@ rte_vhost_enable_guest_notification(int vid, uint16_t queue_id, int enable)
 		return -1;
 
+	if (queue_id >= VHOST_MAX_VRING)
+		return -1;
+
 	vq = dev->virtqueue[queue_id];
+	if (!vq)
+		return -1;
 
 	rte_spinlock_lock(&vq->access_lock);
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-18 16:33:39.047840435 +0000
+++ 0059-vhost-validate-index-in-guest-notification-API.patch	2020-11-18 16:33:37.983215096 +0000
@@ -1 +1 @@
-From 366374054b656e049188216e2fa44831749c2a21 Mon Sep 17 00:00:00 2001
+From c1e34850b7c10c4c8e22f52bd9f73e7184e939ea Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 366374054b656e049188216e2fa44831749c2a21 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -20 +21 @@
-index 193dafc369..801a1a5098 100644
+index 2fd454441a..61754833c2 100644
@@ -23 +24 @@
-@@ -1353,5 +1353,10 @@ rte_vhost_enable_guest_notification(int vid, uint16_t queue_id, int enable)
+@@ -984,5 +984,10 @@ rte_vhost_enable_guest_notification(int vid, uint16_t queue_id, int enable)