[dpdk-stable] patch 'examples/l3fwd-power: check packet types after start' has been queued to LTS release 18.11.11

Kevin Traynor ktraynor at redhat.com
Mon Nov 23 18:12:19 CET 2020


Hi,

FYI, your patch has been queued to LTS release 18.11.11

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/27/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/kevintraynor/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/kevintraynor/dpdk-stable-queue/commit/82297adc98c43bcd82460d107f8c4b115ecca7c7

Thanks.

Kevin.

---
>From 82297adc98c43bcd82460d107f8c4b115ecca7c7 Mon Sep 17 00:00:00 2001
From: Gregory Etelson <getelson at nvidia.com>
Date: Tue, 17 Nov 2020 20:49:39 +0200
Subject: [PATCH] examples/l3fwd-power: check packet types after start

[ upstream commit 6184a02223722b929ae99dff2ba967626448dd63 ]

l3fwd-power uses `--parse-ptype' parameter to query egress packets
type.  Before that feature is enabled l3fwd-power verifies PMD ability
to advertise supported packet types with
rte_eth_dev_get_supported_ptypes().

The above ethdev function API contains this note:
"
Better to invoke this API after the device is already started or rx burst
function is decided, to obtain correct supported ptypes.
"

The patch updates code for PMDs that register supported types after
dev_start.

Fixes: 82bea4661626 ("examples/l3fwd-power: add --parse-ptype option")

Signed-off-by: Gregory Etelson <getelson at nvidia.com>
---
 examples/l3fwd-power/main.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index c2a9d36cb6..4d1f24a1e8 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -2150,7 +2150,5 @@ main(int argc, char **argv)
 					rte_exit(EXIT_FAILURE,
 						 "Fail to add ptype cb\n");
-			} else if (!check_ptype(portid))
-				rte_exit(EXIT_FAILURE,
-					 "PMD can not provide needed ptypes\n");
+			}
 		}
 	}
@@ -2178,4 +2176,9 @@ main(int argc, char **argv)
 		/* initialize spinlock for each port */
 		rte_spinlock_init(&(locks[portid]));
+
+		if (!parse_ptype)
+			if (!check_ptype(portid))
+				rte_exit(EXIT_FAILURE,
+					"PMD can not provide needed ptypes\n");
 	}
 
-- 
2.26.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-23 17:10:14.630943861 +0000
+++ 0027-examples-l3fwd-power-check-packet-types-after-start.patch	2020-11-23 17:10:14.014061609 +0000
@@ -1 +1 @@
-From 6184a02223722b929ae99dff2ba967626448dd63 Mon Sep 17 00:00:00 2001
+From 82297adc98c43bcd82460d107f8c4b115ecca7c7 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 6184a02223722b929ae99dff2ba967626448dd63 ]
+
@@ -21 +22,0 @@
-Cc: stable at dpdk.org
@@ -29 +30 @@
-index 2874285c4e..995a3b6ad7 100644
+index c2a9d36cb6..4d1f24a1e8 100644
@@ -32 +33 @@
-@@ -2708,7 +2708,5 @@ main(int argc, char **argv)
+@@ -2150,7 +2150,5 @@ main(int argc, char **argv)
@@ -41 +42 @@
-@@ -2741,4 +2739,9 @@ main(int argc, char **argv)
+@@ -2178,4 +2176,9 @@ main(int argc, char **argv)



More information about the stable mailing list