[dpdk-stable] patch 'build: fix gcc warning requiring Wformat' has been queued to stable release 19.11.6

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 11/26/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/dd2c4e336023676ec665e94af942ac993d5a7532

Thanks.

Luca Boccassi

---
>From dd2c4e336023676ec665e94af942ac993d5a7532 Mon Sep 17 00:00:00 2001
From: Conor Walsh <conor.walsh at intel.com>
Date: Thu, 19 Nov 2020 10:16:59 +0000
Subject: [PATCH] build: fix gcc warning requiring Wformat

[ upstream commit 654e893436649ca6a876b0bd0f30b4357edc4462 ]

On some CentOS/RHEL systems using gcc 8.3.1 to compile dpdk, gcc shows a
warning on every build step saying that -Wformat-nonliteral and
-Wformat-security warnings will be ignored unless -Wformat is
also specified as a compiler flag. When the build is run with -werror
the build will fail due to these warnings.

Exact warning returned:
cc1: error: -Wformat-nonliteral ignored without -Wformat
[-Werror=format-nonliteral]
cc1: error: -Wformat-security ignored without -Wformat
[-Werror=format-security]
cc1: all warnings being treated as errors

This patch adds the -Wformat flag to config/meson.build. The warning id
181 has also been suppressed in icc as icc was showing false positives
with -Wformat enabled.

Fixes: 524a0d5d66b9 ("build: enable extra warnings with meson")

Signed-off-by: Conor Walsh <conor.walsh at intel.com>
Tested-by: Lingli Chen <linglix.chen at intel.com>
---
 config/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/config/meson.build b/config/meson.build
index fca0461d67..bab00f1489 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -183,6 +183,7 @@ warning_flags = [
 	# additional warnings in alphabetical order
 	'-Wcast-qual',
 	'-Wdeprecated',
+	'-Wformat',
 	'-Wformat-nonliteral',
 	'-Wformat-security',
 	'-Wmissing-declarations',
-- 
2.27.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-11-24 16:50:37.183903447 +0000
+++ 0015-build-fix-gcc-warning-requiring-Wformat.patch	2020-11-24 16:50:36.577496485 +0000
@@ -1 +1 @@
-From 654e893436649ca6a876b0bd0f30b4357edc4462 Mon Sep 17 00:00:00 2001
+From dd2c4e336023676ec665e94af942ac993d5a7532 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 654e893436649ca6a876b0bd0f30b4357edc4462 ]
+
@@ -24 +25,0 @@
-Cc: stable at dpdk.org
@@ -29,2 +30,2 @@
- config/meson.build | 3 ++-
- 1 file changed, 2 insertions(+), 1 deletion(-)
+ config/meson.build | 1 +
+ 1 file changed, 1 insertion(+)
@@ -33 +34 @@
-index a29693b883..c02802c18e 100644
+index fca0461d67..bab00f1489 100644
@@ -36 +37 @@
-@@ -194,6 +194,7 @@ warning_flags = [
+@@ -183,6 +183,7 @@ warning_flags = [
@@ -44,9 +44,0 @@
-@@ -220,7 +221,7 @@ if not dpdk_conf.get('RTE_ARCH_64')
- 	warning_flags += '-Wno-pointer-to-int-cast'
- endif
- if cc.get_id() == 'intel'
--	warning_ids = [188, 2203, 2279, 2557, 3179, 3656]
-+	warning_ids = [181, 188, 2203, 2279, 2557, 3179, 3656]
- 	foreach i:warning_ids
- 		warning_flags += '-diag-disable=@0@'.format(i)
- 	endforeach