[dpdk-stable] [PATCH v2 19.11.6 3/7] net/hns3: report Tx descriptor segment limitations

Luca Boccassi bluca at debian.org
Wed Nov 25 10:16:24 CET 2020


On Wed, 2020-11-25 at 11:24 +0800, Lijun Ou wrote:
> [ upstream commit eb8b3a0d829bc109dfb13de9c8cdeacda5449e69 ]
> 
> According to the user manual of Kunpeng920 SoC, the max allowed number
> of segments per whole packet is 63 and the max number of segments per
> packet is 8 in datapath.
> 
> This patch reports the Two segment parameters of Tx descriptor
> limitations to DPDK framework.
> 
> Signed-off-by: Lijun Ou <oulijun at huawei.com>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei at huawei.com>
> ---
>  drivers/net/hns3/hns3_ethdev.c    | 2 ++
>  drivers/net/hns3/hns3_ethdev_vf.c | 2 ++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
> index 3a92bd4..7fd0f7f 100644
> --- a/drivers/net/hns3/hns3_ethdev.c
> +++ b/drivers/net/hns3/hns3_ethdev.c
> @@ -2499,6 +2499,8 @@ hns3_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
>  		.nb_max = HNS3_MAX_RING_DESC,
>  		.nb_min = HNS3_MIN_RING_DESC,
>  		.nb_align = HNS3_ALIGN_RING_DESC,
> +		.nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT,
> +		.nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT,
>  	};
>  
>  	info->vmdq_queue_num = 0;
> diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
> index 4359b2e..0b5d3d4 100644
> --- a/drivers/net/hns3/hns3_ethdev_vf.c
> +++ b/drivers/net/hns3/hns3_ethdev_vf.c
> @@ -866,6 +866,8 @@ hns3vf_dev_infos_get(struct rte_eth_dev *eth_dev, struct rte_eth_dev_info *info)
>  		.nb_max = HNS3_MAX_RING_DESC,
>  		.nb_min = HNS3_MIN_RING_DESC,
>  		.nb_align = HNS3_ALIGN_RING_DESC,
> +		.nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT,
> +		.nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT,
>  	};
>  
>  	info->vmdq_queue_num = 0;

Hi,

Thanks for the series, but it fails to build, because of this patch:

../drivers/net/hns3/hns3_ethdev.c: In function ‘hns3_dev_infos_get’:
../drivers/net/hns3/hns3_ethdev.c:2502:17: error: ‘HNS3_MAX_TSO_BD_PER_PKT’ undeclared (first use in this function); did you mean ‘HNS3_MAX_TX_BD_PER_PKT’?
   .nb_seg_max = HNS3_MAX_TSO_BD_PER_PKT,
                 ^~~~~~~~~~~~~~~~~~~~~~~
                 HNS3_MAX_TX_BD_PER_PKT
../drivers/net/hns3/hns3_ethdev.c:2502:17: note: each undeclared identifier is reported only once for each function it appears in
../drivers/net/hns3/hns3_ethdev.c:2503:21: error: ‘HNS3_MAX_NON_TSO_BD_PER_PKT’ undeclared (first use in this function); did you mean ‘HNS3_MAX_TX_BD_PER_PKT’?
   .nb_mtu_seg_max = HNS3_MAX_NON_TSO_BD_PER_PKT,
                     ^~~~~~~~~~~~~~~~~~~~~~~~~~~
                     HNS3_MAX_TX_BD_PER_PKT
[3/32] Compiling C object 'drivers/a715181@@tmp_rte_pmd_hns3 at sta/net_hns3_hns3_intr.c.o'.
ninja: build stopped: subcommand failed.

-- 
Kind regards,
Luca Boccassi


More information about the stable mailing list