[dpdk-stable] [PATCH v3] net/dpaa2: fix build error about timesync functions

Ferruh Yigit ferruh.yigit at intel.com
Fri Oct 9 13:22:41 CEST 2020


On 10/9/2020 8:48 AM, Sachin Saxena (OSS) wrote:

> On 08-Oct-20 6:42 PM, Ferruh Yigit wrote:
>> On 10/8/2020 3:24 AM, Sachin Saxena (OSS) wrote:
>>
>> [please don't top post, I moved reply to down]
>>
>>>
>>> On 06-Oct-20 10:46 PM, Ferruh Yigit wrote:
>>>> From: Chenxu Di<chenxux.di at intel.com>
>>>>
>>>> Some timesync related source files are built only when
>>>> 'RTE_LIBRTE_IEEE1588' config is set, which is missing in meson.
>>>>
>>>> Building with '-DRTE_LIBRTE_IEEE1588' cflag will enable timesync
>>>> functionality in the files that are build, but it won't build files
>>>> that require 'RTE_LIBRTE_IEEE1588' config.
>>>> This causes the build error.
>>>>
>>>> Fixing by removing config check in meson file and build all .c files by
>>>> default, but wrap relevant code part with 'RTE_LIBRTE_IEEE1588' macro.
>>>>
>>>> Also removing 'RTE_LIBRTE_IEEE1588' ifdef around some fields of the data
>>>> structures, to not require finer grained macro wraps on the functions
>>>> using them.
>>>> Since the registration of the function disabled with macro check, having
>>>> functions compiled shouldn't affect the functionality.
>>>>
>>>> Fixes: 184c39d16568 ("net/dpaa2: add DPRTC sub-module")
>>>> Cc:stable at dpdk.org
>>>>
>>>> Signed-off-by: Chenxu Di<chenxux.di at intel.com>
>>>> Signed-off-by: Ferruh Yigit<ferruh.yigit at intel.com>
 >
 > Acked-by: Sachin Saxena<sachin.saxena at oss.nxp.com>
 >

Applied to dpdk-next-net/main, thanks.


More information about the stable mailing list