[dpdk-stable] patch 'net/iavf: fix setting of MAC address' has been queued to stable release 19.11.6

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 45120d61c2a497396d638cdae6c458f97d897b82 Mon Sep 17 00:00:00 2001
From: Steve Yang <stevex.yang at intel.com>
Date: Fri, 4 Sep 2020 07:29:05 +0000
Subject: [PATCH] net/iavf: fix setting of MAC address

[ upstream commit dd52fa0bade3d9e8bbb2229309c9f020cbe6872f ]

When setting the MAC address, the ethdev layer copies the new mac
address in dev->data->mac_addrs[0] before calling the dev_ops.

Therefore, is_same_ether_addr(mac_addr, dev->data->mac_addrs) was
always true, and the MAC was never set. Remove this test to fix the
issue.

Fixes: 538da7a1cad2 ("net: add rte prefix to ether functions")

Signed-off-by: Steve Yang <stevex.yang at intel.com>
Acked-by: Beilei Xing <beilei.xing at intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index d65412ae94..a60b04ddd5 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -987,9 +987,6 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
 	old_addr = (struct rte_ether_addr *)hw->mac.addr;
 	perm_addr = (struct rte_ether_addr *)hw->mac.perm_addr;
 
-	if (rte_is_same_ether_addr(mac_addr, old_addr))
-		return 0;
-
 	/* If the MAC address is configured by host, skip the setting */
 	if (rte_is_valid_assigned_ether_addr(perm_addr))
 		return -EPERM;
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:12.479276588 +0000
+++ 0022-net-iavf-fix-setting-of-MAC-address.patch	2020-10-28 10:35:11.444829140 +0000
@@ -1,8 +1,10 @@
-From dd52fa0bade3d9e8bbb2229309c9f020cbe6872f Mon Sep 17 00:00:00 2001
+From 45120d61c2a497396d638cdae6c458f97d897b82 Mon Sep 17 00:00:00 2001
 From: Steve Yang <stevex.yang at intel.com>
 Date: Fri, 4 Sep 2020 07:29:05 +0000
 Subject: [PATCH] net/iavf: fix setting of MAC address
 
+[ upstream commit dd52fa0bade3d9e8bbb2229309c9f020cbe6872f ]
+
 When setting the MAC address, the ethdev layer copies the new mac
 address in dev->data->mac_addrs[0] before calling the dev_ops.
 
@@ -11,7 +13,6 @@
 issue.
 
 Fixes: 538da7a1cad2 ("net: add rte prefix to ether functions")
-Cc: stable at dpdk.org
 
 Signed-off-by: Steve Yang <stevex.yang at intel.com>
 Acked-by: Beilei Xing <beilei.xing at intel.com>
@@ -20,10 +21,10 @@
  1 file changed, 3 deletions(-)
 
 diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
-index 5f3aea8a04..8e1d8a8d3e 100644
+index d65412ae94..a60b04ddd5 100644
 --- a/drivers/net/iavf/iavf_ethdev.c
 +++ b/drivers/net/iavf/iavf_ethdev.c
-@@ -1020,9 +1020,6 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
+@@ -987,9 +987,6 @@ iavf_dev_set_default_mac_addr(struct rte_eth_dev *dev,
  	old_addr = (struct rte_ether_addr *)hw->mac.addr;
  	perm_addr = (struct rte_ether_addr *)hw->mac.perm_addr;