[dpdk-stable] patch 'net/qede: fix getting link details' has been queued to stable release 19.11.6

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Oct 28 11:44:43 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 6efa54e3430982b3f868a023e76b5dc95b40c481 Mon Sep 17 00:00:00 2001
From: Rasesh Mody <rmody at marvell.com>
Date: Fri, 2 Oct 2020 12:59:45 -0700
Subject: [PATCH] net/qede: fix getting link details

[ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ]

This patch fixes get current link details, without this change the link
details can be inaccurate if proper lock is not acquired.

Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")

Reported-by: Ferruh Yigit <ferruh.yigit at intel.com>
Signed-off-by: Rasesh Mody <rmody at marvell.com>
Signed-off-by: Igor Russkikh <irusskikh at marvell.com>
---
 drivers/net/qede/qede_main.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
index 8580cbcd7f..67392d6aa4 100644
--- a/drivers/net/qede/qede_main.c
+++ b/drivers/net/qede/qede_main.c
@@ -575,13 +575,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
 	hwfn = &edev->hwfns[0];
 	if (IS_PF(edev)) {
 		ptt = ecore_ptt_acquire(hwfn);
-		if (!ptt)
-			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
-
+		if (ptt) {
 			qed_fill_link(hwfn, ptt, if_link);
-
-		if (ptt)
 			ecore_ptt_release(hwfn, ptt);
+		} else {
+			DP_NOTICE(hwfn, true, "Failed to fill link; No PTT\n");
+		}
 	} else {
 		qed_fill_link(hwfn, NULL, if_link);
 	}
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:15.600550906 +0000
+++ 0124-net-qede-fix-getting-link-details.patch	2020-10-28 10:35:11.684832673 +0000
@@ -1,13 +1,14 @@
-From effb1d0b9527815a7cd5422bce5defbc0884cea0 Mon Sep 17 00:00:00 2001
+From 6efa54e3430982b3f868a023e76b5dc95b40c481 Mon Sep 17 00:00:00 2001
 From: Rasesh Mody <rmody at marvell.com>
 Date: Fri, 2 Oct 2020 12:59:45 -0700
 Subject: [PATCH] net/qede: fix getting link details
 
+[ upstream commit effb1d0b9527815a7cd5422bce5defbc0884cea0 ]
+
 This patch fixes get current link details, without this change the link
 details can be inaccurate if proper lock is not acquired.
 
 Fixes: 739a5b2f2b49 ("net/qede/base: use passed ptt handler")
-Cc: stable at dpdk.org
 
 Reported-by: Ferruh Yigit <ferruh.yigit at intel.com>
 Signed-off-by: Rasesh Mody <rmody at marvell.com>
@@ -17,10 +18,10 @@
  1 file changed, 4 insertions(+), 5 deletions(-)
 
 diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c
-index 0d3cea6e42..caa9d1d4f6 100644
+index 8580cbcd7f..67392d6aa4 100644
 --- a/drivers/net/qede/qede_main.c
 +++ b/drivers/net/qede/qede_main.c
-@@ -587,13 +587,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
+@@ -575,13 +575,12 @@ qed_get_current_link(struct ecore_dev *edev, struct qed_link_output *if_link)
  	hwfn = &edev->hwfns[0];
  	if (IS_PF(edev)) {
  		ptt = ecore_ptt_acquire(hwfn);


More information about the stable mailing list