[dpdk-stable] patch 'eventdev: fix adapter leak in error path' has been queued to stable release 19.11.6

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Oct 28 11:45:17 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From 0da6f9ab3f97ac8234667c32c30302328c8b6b23 Mon Sep 17 00:00:00 2001
From: Yunjian Wang <wangyunjian at huawei.com>
Date: Tue, 29 Sep 2020 21:46:33 +0800
Subject: [PATCH] eventdev: fix adapter leak in error path

[ upstream commit b7b09dab5e9507541222d1d2ce86f55e9eb32b9e ]

In rte_event_crypto_adapter_create_ext() allocated memory for
adapter, we should free it when error happens, otherwise it
will lead to memory leak.

Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")

Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Jerin Jacob <jerinj at marvell.com>
---
 lib/librte_eventdev/rte_event_crypto_adapter.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c
index 22d9108168..db9af8c200 100644
--- a/lib/librte_eventdev/rte_event_crypto_adapter.c
+++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
@@ -240,6 +240,7 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id,
 	if (ret < 0) {
 		RTE_EDEV_LOG_ERR("Failed to get info for eventdev %d: %s!",
 				 dev_id, dev_info.driver_name);
+		rte_free(adapter);
 		return ret;
 	}
 
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:16.638291516 +0000
+++ 0158-eventdev-fix-adapter-leak-in-error-path.patch	2020-10-28 10:35:11.756833733 +0000
@@ -1,14 +1,15 @@
-From b7b09dab5e9507541222d1d2ce86f55e9eb32b9e Mon Sep 17 00:00:00 2001
+From 0da6f9ab3f97ac8234667c32c30302328c8b6b23 Mon Sep 17 00:00:00 2001
 From: Yunjian Wang <wangyunjian at huawei.com>
 Date: Tue, 29 Sep 2020 21:46:33 +0800
 Subject: [PATCH] eventdev: fix adapter leak in error path
 
+[ upstream commit b7b09dab5e9507541222d1d2ce86f55e9eb32b9e ]
+
 In rte_event_crypto_adapter_create_ext() allocated memory for
 adapter, we should free it when error happens, otherwise it
 will lead to memory leak.
 
 Fixes: 7901eac3409a ("eventdev: add crypto adapter implementation")
-Cc: stable at dpdk.org
 
 Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
 Acked-by: Jerin Jacob <jerinj at marvell.com>
@@ -17,10 +18,10 @@
  1 file changed, 1 insertion(+)
 
 diff --git a/lib/librte_eventdev/rte_event_crypto_adapter.c b/lib/librte_eventdev/rte_event_crypto_adapter.c
-index 8f25933163..b04312128a 100644
+index 22d9108168..db9af8c200 100644
 --- a/lib/librte_eventdev/rte_event_crypto_adapter.c
 +++ b/lib/librte_eventdev/rte_event_crypto_adapter.c
-@@ -241,6 +241,7 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id,
+@@ -240,6 +240,7 @@ rte_event_crypto_adapter_create_ext(uint8_t id, uint8_t dev_id,
  	if (ret < 0) {
  		RTE_EDEV_LOG_ERR("Failed to get info for eventdev %d: %s!",
  				 dev_id, dev_info.driver_name);


More information about the stable mailing list