[dpdk-stable] patch 'test/distributor: fix quitting workers in burst mode' has been queued to stable release 19.11.6

luca.boccassi at gmail.com luca.boccassi at gmail.com
Wed Oct 28 11:45:56 CET 2020


Hi,

FYI, your patch has been queued to stable release 19.11.6

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 10/30/20. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Thanks.

Luca Boccassi

---
>From c2a92ce0d1bcda8472995a3577263f06cf30b73f Mon Sep 17 00:00:00 2001
From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Date: Sat, 17 Oct 2020 05:07:01 +0200
Subject: [PATCH] test/distributor: fix quitting workers in burst mode

[ upstream commit f72bff0ec2723b7d7bfc9c655419030b1c8fffad ]

Sending number of packets equal to number of workers isn't enough
to stop all workers in burst version of distributor as more than
one packet can be matched and consumed by a single worker. This way
some of workers might not be awaken from rte_distributor_get_pkt().

This patch fixes it by sending packets one by one. Each sent packet
causes exactly one worker to quit.

Fixes: 775003ad2f96 ("distributor: add new burst-capable library")

Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
---
 app/test/test_distributor.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
index 199f88887d..281b015363 100644
--- a/app/test/test_distributor.c
+++ b/app/test/test_distributor.c
@@ -629,9 +629,10 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)
 
 	zero_quit = 0;
 	quit = 1;
-	for (i = 0; i < num_workers; i++)
+	for (i = 0; i < num_workers; i++) {
 		bufs[i]->hash.usr = i << 1;
-	rte_distributor_process(d, bufs, num_workers);
+		rte_distributor_process(d, &bufs[i], 1);
+	}
 
 	rte_distributor_process(d, NULL, 0);
 	rte_distributor_flush(d);
-- 
2.20.1

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2020-10-28 10:35:17.798551373 +0000
+++ 0197-test-distributor-fix-quitting-workers-in-burst-mode.patch	2020-10-28 10:35:11.804834440 +0000
@@ -1,8 +1,10 @@
-From f72bff0ec2723b7d7bfc9c655419030b1c8fffad Mon Sep 17 00:00:00 2001
+From c2a92ce0d1bcda8472995a3577263f06cf30b73f Mon Sep 17 00:00:00 2001
 From: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
 Date: Sat, 17 Oct 2020 05:07:01 +0200
 Subject: [PATCH] test/distributor: fix quitting workers in burst mode
 
+[ upstream commit f72bff0ec2723b7d7bfc9c655419030b1c8fffad ]
+
 Sending number of packets equal to number of workers isn't enough
 to stop all workers in burst version of distributor as more than
 one packet can be matched and consumed by a single worker. This way
@@ -12,7 +14,6 @@
 causes exactly one worker to quit.
 
 Fixes: 775003ad2f96 ("distributor: add new burst-capable library")
-Cc: stable at dpdk.org
 
 Signed-off-by: Lukasz Wojciechowski <l.wojciechow at partner.samsung.com>
 Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>
@@ -21,10 +22,10 @@
  1 file changed, 3 insertions(+), 2 deletions(-)
 
 diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c
-index a4af0a39c6..e0cb698e1c 100644
+index 199f88887d..281b015363 100644
 --- a/app/test/test_distributor.c
 +++ b/app/test/test_distributor.c
-@@ -769,9 +769,10 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)
+@@ -629,9 +629,10 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p)
  
  	zero_quit = 0;
  	quit = 1;


More information about the stable mailing list