[dpdk-stable] [dpdk-dev] [PATCH] metrics: fix resource leak on memory allocation fail

[Power, Ciara]

Hi Honnappa,

>-----Original Message-----
>From: Honnappa Nagarahalli <Honnappa.Nagarahalli at arm.com>
>Sent: Tuesday 22 September 2020 00:43
>To: Mcnamara, John <john.mcnamara at intel.com>; Power, Ciara
><ciara.power at intel.com>; dev at dpdk.org
>Cc: Power, Ciara <ciara.power at intel.com>; stable at dpdk.org; Wiles, Keith
><keith.wiles at intel.com>; nd <nd at arm.com>; Honnappa Nagarahalli
><Honnappa.Nagarahalli at arm.com>; nd <nd at arm.com>
>Subject: RE: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on
>memory allocation fail
>
><snip>
>
>>
>> > If an error occurred when allocating memory for metrics or names,
>> > the function returned without freeing allocated memory. This is now
>> > fixed to avoid the resource leak in the case that either metrics or
>> > names had been successfully allocated memory.
>> >
>> > Coverity issue: 362053
>> > Fixes: c5b7197f662e ("telemetry: move some functions to metrics
>> > library")
>> > Cc: stable at dpdk.org
>>
>> Acked-by: John McNamara <john.mcnamara at intel.com>
>>
>This is fixed in https://patches.dpdk.org/patch/75323/. Can you please check
>if that suffices?

I left some comments on that patch, but seeing as it is fixing the same issue, I will remove this patch.

Thanks,
Ciara