[dpdk-stable] [PATCH v2 1/1] raw/ifpga/base: check size before assigning

Xu, Rosen rosen.xu at intel.com
Tue Apr 20 03:59:49 CEST 2021


Thanks all.

-----Original Message-----
From: Yigit, Ferruh <ferruh.yigit at intel.com> 
Sent: Tuesday, April 20, 2021 9:01 AM
To: Zhang, Tianfei <tianfei.zhang at intel.com>; Zhang, Qi Z <qi.z.zhang at intel.com>; Huang, Wei <wei.huang at intel.com>; dev at dpdk.org; Xu, Rosen <rosen.xu at intel.com>
Cc: stable at dpdk.org
Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before assigning

On 4/20/2021 1:13 AM, Zhang, Tianfei wrote:
> 
> 
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit at intel.com>
>> Sent: 2021年4月20日 6:36
>> To: Zhang, Qi Z <qi.z.zhang at intel.com>; Huang, Wei 
>> <wei.huang at intel.com>; dev at dpdk.org; Xu, Rosen <rosen.xu at intel.com>
>> Cc: stable at dpdk.org; Zhang, Tianfei <tianfei.zhang at intel.com>
>> Subject: Re: [PATCH v2 1/1] raw/ifpga/base: check size before 
>> assigning
>>
>> On 4/19/2021 9:12 AM, Zhang, Qi Z wrote:
>>>
>>>
>>>> -----Original Message-----
>>>> From: Huang, Wei <wei.huang at intel.com>
>>>> Sent: Thursday, April 8, 2021 4:52 PM
>>>> To: dev at dpdk.org; Xu, Rosen <rosen.xu at intel.com>; Zhang, Qi Z 
>>>> <qi.z.zhang at intel.com>
>>>> Cc: stable at dpdk.org; Zhang, Tianfei <tianfei.zhang at intel.com>; 
>>>> Yigit, Ferruh <ferruh.yigit at intel.com>; Huang, Wei 
>>>> <wei.huang at intel.com>
>>>> Subject: [PATCH v2 1/1] raw/ifpga/base: check size before assigning
>>>>
>>>> In max10_staging_area_init(), variable "size" from fdt_get_reg() 
>>>> may be invalid, it should be checked before assigning to member 
>>>> variable
>> "staging_area_size"
>>>> of structure "intel_max10_device".
>>>>
>>>> Coverity issue: 367480, 367482
>>>> Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device
>>>> driver")
>>>>
>>>> Signed-off-by: Wei Huang <wei.huang at intel.com>
>>>> ---
>>>
>>> Applied to dpdk-next-net-intel.
>>>
>>
>> This patch is missing the maintainer ack.
>>
>> Rosen, Tianfei, can you please review the patch?
> 
> It looks good for me.
> 
> Acked-by: Tianfei zhang <Tianfei.zhang at intel.com>
> 

Thanks, added in next-net.


More information about the stable mailing list