[dpdk-stable] [PATCH] compress/mlx5: fix level translation in xform API

Thomas Monjalon thomas at monjalon.net
Tue Aug 3 14:11:44 CEST 2021


01/08/2021 08:13, Matan Azrad:
> From: Raja Zidane
> > Compression Level is interpreted by each PMD differently.
> > However, lower numbers give faster compression at the expense of
> > compression ratio, while higher numbers may give better compression ratios
> > but are likely slower.
> > The level affects the block size, which affects performance, the bigger the
> > block, the faster the compression is.
> > 
> > The problem was that higher levels caused bigger blocks:
> >   size = min_block_size - 1 + level.
> > 
> > the solution is to reverse the above:
> >   size = max_block_size + 1 - level.
> > 
> > Fixes: 39a2c8715f8f ("compress/mlx5: add transformation operations")
> > Cc: matan at nvidia.com
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Raja Zidane <rzidane at nvidia.com>
> 
> Congrats on your first patch, Raja!

The explanation above is very clear, thank you and
congratulations!

> Acked-by: Matan Azrad <matan at nvidia.com>

Applied, thanks.




More information about the stable mailing list