[dpdk-stable] patch 'net/virtio: fix default duplex mode' has been queued to stable release 20.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Tue Aug 3 14:21:53 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/05/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/13ac5a51019ce36dd5de8a83d2298f54de487888

Thanks.

Luca Boccassi

---
>From 13ac5a51019ce36dd5de8a83d2298f54de487888 Mon Sep 17 00:00:00 2001
From: Chenbo Xia <chenbo.xia at intel.com>
Date: Tue, 27 Jul 2021 13:14:41 +0800
Subject: [PATCH] net/virtio: fix default duplex mode

[ upstream commit 1e9221ae38dddb4abe75a7b3afaecbaa4b8e0523 ]

When virtio front-end initializes, the duplex mode should be set
unknown before reading any duplex mode information from configuration
space. This patch fixes the issue that duplex mode is by default set
to zero, which equals ETH_LINK_HALF_DUPLEX. This will lead to duplex
mode being half duplex when front-end does not have the feature
named VIRTIO_NET_F_SPEED_DUPLEX.

Fixes: 1357b4b36246 ("net/virtio: support Virtio link speed feature")

Signed-off-by: Chenbo Xia <chenbo.xia at intel.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
---
 drivers/net/virtio/virtio_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c
index f87c931d13..520f3fde54 100644
--- a/drivers/net/virtio/virtio_ethdev.c
+++ b/drivers/net/virtio/virtio_ethdev.c
@@ -1994,6 +1994,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
 	if (ret < 0)
 		return ret;
 	hw->speed = speed;
+	hw->duplex = DUPLEX_UNKNOWN;
 
 	/* Allocate memory for storing MAC addresses */
 	eth_dev->data->mac_addrs = rte_zmalloc("virtio",
-- 
2.30.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-08-03 12:35:08.394240586 +0100
+++ 0004-net-virtio-fix-default-duplex-mode.patch	2021-08-03 12:35:08.170817850 +0100
@@ -1 +1 @@
-From 1e9221ae38dddb4abe75a7b3afaecbaa4b8e0523 Mon Sep 17 00:00:00 2001
+From 13ac5a51019ce36dd5de8a83d2298f54de487888 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 1e9221ae38dddb4abe75a7b3afaecbaa4b8e0523 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -23 +24 @@
-index a4adeec5ab..e58085a2c9 100644
+index f87c931d13..520f3fde54 100644
@@ -26 +27 @@
-@@ -1901,6 +1901,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
+@@ -1994,6 +1994,7 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)


More information about the stable mailing list