[dpdk-stable] patch 'net/pfe: remove unnecessary null check' has been queued to stable release 19.11.10

christian.ehrhardt at canonical.com christian.ehrhardt at canonical.com
Tue Aug 10 17:39:13 CEST 2021


Hi,

FYI, your patch has been queued to stable release 19.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/704a3314ef03076bfa9ba120a74de97578f6a01f

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 704a3314ef03076bfa9ba120a74de97578f6a01f Mon Sep 17 00:00:00 2001
From: Thierry Herbelot <thierry.herbelot at 6wind.com>
Date: Mon, 24 May 2021 11:37:54 +0200
Subject: [PATCH] net/pfe: remove unnecessary null check

[ upstream commit 01bfb518a39b91da7896abe579bcf72d06935bf5 ]

ethdev library does the check of dev before calling the link update.

Fixes: acd4818ea2a45 ("net/pfe: add link status update")

Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
Acked-by: Gagandeep Singh <g.singh at nxp.com>
---
 drivers/net/pfe/pfe_ethdev.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c
index fa3c0ce0fe..4e2ba0565f 100644
--- a/drivers/net/pfe/pfe_ethdev.c
+++ b/drivers/net/pfe/pfe_ethdev.c
@@ -583,11 +583,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)
 	struct rte_eth_link link, old;
 	unsigned int lstatus = 1;
 
-	if (dev == NULL) {
-		PFE_PMD_ERR("Invalid device in link_update.\n");
-		return 0;
-	}
-
 	memset(&old, 0, sizeof(old));
 	memset(&link, 0, sizeof(struct rte_eth_link));
 
-- 
2.32.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-08-10 15:11:14.343734353 +0200
+++ 0033-net-pfe-remove-unnecessary-null-check.patch	2021-08-10 15:11:12.970637754 +0200
@@ -1 +1 @@
-From 01bfb518a39b91da7896abe579bcf72d06935bf5 Mon Sep 17 00:00:00 2001
+From 704a3314ef03076bfa9ba120a74de97578f6a01f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 01bfb518a39b91da7896abe579bcf72d06935bf5 ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org
@@ -18 +19 @@
-index 3135466713..feec4d10a2 100644
+index fa3c0ce0fe..4e2ba0565f 100644
@@ -21 +22 @@
-@@ -582,11 +582,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)
+@@ -583,11 +583,6 @@ pfe_eth_link_update(struct rte_eth_dev *dev, int wait_to_complete __rte_unused)


More information about the stable mailing list