[dpdk-stable] patch 'doc: add limitation for ConnectX-4 with L2 in mlx5 guide' has been queued to stable release 19.11.10

[christian.ehrhardt at canonical.com]

Hi,

FYI, your patch has been queued to stable release 19.11.10

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/12/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/cpaelzer/dpdk-stable-queue

This queued commit can be viewed at:
https://github.com/cpaelzer/dpdk-stable-queue/commit/9910c05442d047432d15c8721726dabdc88b478c

Thanks.

Christian Ehrhardt <christian.ehrhardt at canonical.com>

---
>From 9910c05442d047432d15c8721726dabdc88b478c Mon Sep 17 00:00:00 2001
From: Dmitry Kozlyuk <dkozlyuk at nvidia.com>
Date: Wed, 30 Jun 2021 10:01:06 +0300
Subject: [PATCH] doc: add limitation for ConnectX-4 with L2 in mlx5 guide

[ upstream commit e60561cc955ac01512a35ca309793e351cef3c9b ]

ConnectX-4 and ConnectX-4 Lx NICs require all L2 headers of transmitted
packets to be inlined. By default only first 18 bytes are inlined,
which is insufficient if additional encapsulation is used, like Q-in-Q.
Thus, default settings caused such traffic to be dropepd on Tx.
Document a recommendation to increase inlined data size in such cases.

Fixes: 505f1fe426d3 ("net/mlx5: add Tx devargs")

Signed-off-by: Dmitry Kozlyuk <dkozlyuk at nvidia.com>
Reviewed-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
---
 doc/guides/nics/mlx5.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index bbad7d0d5b..3ce4fda641 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -498,6 +498,13 @@ Run-time configuration
   it is not recommended and may prevent NIC from sending packets over
   some configurations.
 
+  For ConnectX-4 and ConnectX-4 Lx NICs, automatically configured value
+  is insufficient for some traffic, because they require at least all L2 headers
+  to be inlined. For example, Q-in-Q adds 4 bytes to default 18 bytes
+  of Ethernet and VLAN, thus ``txq_inline_min`` must be set to 22.
+  MPLS would add 4 bytes per label. Final value must account for all possible
+  L2 encapsulation headers used in particular environment.
+
   Please, note, this minimal data inlining disengages eMPW feature (Enhanced
   Multi-Packet Write), because last one does not support partial packet inlining.
   This is not very critical due to minimal data inlining is mostly required
-- 
2.32.0

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-08-10 15:11:15.032307837 +0200
+++ 0052-doc-add-limitation-for-ConnectX-4-with-L2-in-mlx5-gu.patch	2021-08-10 15:11:13.030638186 +0200
@@ -1 +1 @@
-From e60561cc955ac01512a35ca309793e351cef3c9b Mon Sep 17 00:00:00 2001
+From 9910c05442d047432d15c8721726dabdc88b478c Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit e60561cc955ac01512a35ca309793e351cef3c9b ]
+
@@ -13 +14,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 0d96eec2bb..5b4bb13914 100644
+index bbad7d0d5b..3ce4fda641 100644
@@ -25 +26 @@
-@@ -700,6 +700,13 @@ Driver options
+@@ -498,6 +498,13 @@ Run-time configuration