[PATCH 2/3] net/mlx5: improve stride parameter names

Michael Baum michaelba at nvidia.com
Wed Dec 8 13:52:49 CET 2021


On 12/07/2021 3:34 PM, ferruh.yigit at intel.com wrote: 
> 
> On 11/23/2021 6:38 PM, michaelba at nvidia.com wrote:
> > From: Michael Baum<michaelba at nvidia.com>
> >
> > In the striding RQ management there are two important parameters, the
> > size of the single stride in bytes and the number of strides.
> >
> > Both the data-path structure and config structure keep the log of the
> > above parameters. However, in their names there is no mention that the
> > value is a log which may be misleading as if the fields represent the
> > values themselves.
> >
> > This patch updates their names describing the values more accurately.
> >
> > Cc:stable at dpdk.org
> >
> 
> Can you please provide fixes tag for it?

I think this is the relevant fixes tag:
Fixes: ecb160456aed ("net/mlx5: add device parameter for MPRQ stride size")

> In this case commit(s) adding the parameters with bad name.

I added Cc:stable here just to make next commit easy for the backport, because following patch is based on it.
For this commit itself there is no reason backporting it ,because it does not solve something that affects the user but prevents confusion from future programmers.

> 
> > Signed-off-by: Michael Baum<michaelba at nvidia.com>
> > Acked-by: Matan Azrad<matan at nvidia.com>



More information about the stable mailing list