[PATCH 2/3] crypto/ipsec_mb: fix qp cleanup null pointer dereference
Ciara Power
ciara.power at intel.com
Fri Dec 10 15:09:51 CET 2021
The qp was being used in the cleanup without checking if it was non NULL.
A check is now added to verify qp is non NULL before use.
Coverity issue: 374375
Fixes: c75542ae4200 ("crypto/ipsec_mb: introduce IPsec_mb framework")
Cc: roy.fan.zhang at intel.com
Cc: stable at dpdk.org
Signed-off-by: Ciara Power <ciara.power at intel.com>
---
drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
index 6efa417d67..1ebd23e8f0 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c
@@ -285,6 +285,8 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
return 0;
qp_setup_cleanup:
+ if (qp == NULL)
+ return ret;
#if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM
if (qp->mb_mgr)
free_mb_mgr(qp->mb_mgr);
@@ -294,8 +296,7 @@ ipsec_mb_qp_setup(struct rte_cryptodev *dev, uint16_t qp_id,
if (qp->mb_mgr_mz)
rte_memzone_free(qp->mb_mgr_mz);
#endif
- if (qp)
- rte_free(qp);
+ rte_free(qp);
return ret;
}
--
2.25.1
More information about the stable
mailing list