[PATCH v3] eal: allow to exclude memseg from core dump

[Dmitry Kozlyuk]

2021-12-15 17:36 (UTC+0530), Jerin Jacob:
[...]
> > diff --git a/lib/eal/unix/eal_unix_memory.c b/lib/eal/unix/eal_unix_memory.c
> > index 68ae93bd6e..44227aee95 100644
> > --- a/lib/eal/unix/eal_unix_memory.c
> > +++ b/lib/eal/unix/eal_unix_memory.c
> > @@ -83,10 +83,13 @@ eal_mem_set_dump(void *virt, size_t size, bool dump)
> >         int flags = dump ? EAL_DODUMP : EAL_DONTDUMP;
> >         int ret = madvise(virt, size, flags);
> >         if (ret) {
> > -               RTE_LOG(DEBUG, EAL, "madvise(%p, %#zx, %d) failed: %s\n",
> > +               RTE_LOG(INFO, EAL, "madvise(%p, %#zx, %d) failed: %s\n",
> >                                 virt, size, flags, strerror(rte_errno));  
> 
> probably ERR instead of INFO.
> 
> 
> >                 rte_errno = errno;
> > -       }
> > +       } else
> > +               RTE_LOG(INFO, EAL, "madvise(%p, %#zx, %d) success: %s\n",
> > +                               virt, size, flags, __func__);  
> 
> This should be DEBUG. Not INFO.

Usually errors from OS API are reported as DEBUG in EAL,
so the first one should also remain DEBUG.