[dpdk-stable] [PATCH] config/arm: fix typo in meson config

Honnappa Nagarahalli Honnappa.Nagarahalli at arm.com
Tue Feb 2 00:22:10 CET 2021


<snip>

> Subject: [PATCH] config/arm: fix typo in meson config
> 
> s/implementor/implementer
> 
> Fixes: 3d01d65ba0d3 ("config: add aarch64 clang for Ubuntu 18.04")
> Fixes: c51401832147 ("config/arm: add Graviton2")
> Cc: stable at dpdk.org
> 
> Reported-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
> Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli at arm.com>

Thanks Ferruh. I remember discussing this on the list. I am fine with 'implementEr' as that is what is used in Arm public specs.

> ---
> Cc: Juraj Linkeš <juraj.linkes at pantheon.tech>
> Cc: Ruifeng Wang <ruifeng.wang at arm.com>
> Cc: vcchunga at amazon.com
> ---
>  config/arm/arm64_armv8_linux_clang_ubuntu1804 | 4 ++--
>  config/arm/arm64_graviton2_linux_gcc          | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> index aa5ee0132065..ae3fb30c5da8 100644
> --- a/config/arm/arm64_armv8_linux_clang_ubuntu1804
> +++ b/config/arm/arm64_armv8_linux_clang_ubuntu1804
> @@ -14,7 +14,7 @@ cpu = 'armv8-a'
>  endian = 'little'
> 
>  [properties]
> -implementor_id = 'generic'
> -implementor_pn = 'default'
> +implementer_id = 'generic'
> +implementer_pn = 'default'
>  c_args = ['-target', 'aarch64-linux-gnu', '--sysroot', '/usr/aarch64-linux-gnu']
> c_link_args = ['-target', 'aarch64-linux-gnu', '-fuse-ld=lld', '--gcc-
> toolchain=/usr'] diff --git a/config/arm/arm64_graviton2_linux_gcc
> b/config/arm/arm64_graviton2_linux_gcc
> index cfe2397975fc..123f14eed29e 100644
> --- a/config/arm/arm64_graviton2_linux_gcc
> +++ b/config/arm/arm64_graviton2_linux_gcc
> @@ -13,8 +13,8 @@ cpu = 'armv8-a'
>  endian = 'little'
> 
>  [properties]
> -implementor_id = '0x41'
> -implementor_pn = '0xd0c'
> +implementer_id = '0x41'
> +implementer_pn = '0xd0c'
>  max_lcores = 64
>  max_numa_nodes = 1
>  numa = false
> --
> 2.29.2



More information about the stable mailing list