[dpdk-stable] patch 'net/bonding: fix port id validity check on parsing' has been queued to stable release 20.11.1

[luca.boccassi at gmail.com]

Hi,

FYI, your patch has been queued to stable release 20.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/64fdf34d136ecc642bcecb3f133470844e02e33e

Thanks.

Luca Boccassi

---
>From 64fdf34d136ecc642bcecb3f133470844e02e33e Mon Sep 17 00:00:00 2001
From: Gaetan Rivet <grive at u256.net>
Date: Fri, 17 Apr 2020 18:42:06 +0200
Subject: [PATCH] net/bonding: fix port id validity check on parsing

[ upstream commit 44cd624a4b8c626fb5444199c06b5e05675c3cc1 ]

If the port_id is equal to RTE_MAX_ETHPORTS, it should be considered
invalid. Additionally, UNUSED ports are also not valid port ids to be
used afterward.

To simplify following the ethdev API rules, use the exposed function
checking whether a port id is valid.

Fixes: 2efb58cbab6e ("bond: new link bonding library")

Signed-off-by: Gaetan Rivet <grive at u256.net>
Acked-by: Min Hu (Connor) <humin29 at huawei.com>
---
 drivers/net/bonding/rte_eth_bond_args.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c
index abdf552610..35616fb8bc 100644
--- a/drivers/net/bonding/rte_eth_bond_args.c
+++ b/drivers/net/bonding/rte_eth_bond_args.c
@@ -108,9 +108,8 @@ parse_port_id(const char *port_str)
 		}
 	}
 
-	if (port_id < 0 || port_id > RTE_MAX_ETHPORTS) {
-		RTE_BOND_LOG(ERR, "Slave port specified (%s) outside expected range",
-				port_str);
+	if (!rte_eth_dev_is_valid_port(port_id)) {
+		RTE_BOND_LOG(ERR, "Specified port (%s) is invalid", port_str);
 		return -1;
 	}
 	return port_id;
-- 
2.29.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-02-05 11:18:30.380473090 +0000
+++ 0024-net-bonding-fix-port-id-validity-check-on-parsing.patch	2021-02-05 11:18:28.606687304 +0000
@@ -1 +1 @@
-From 44cd624a4b8c626fb5444199c06b5e05675c3cc1 Mon Sep 17 00:00:00 2001
+From 64fdf34d136ecc642bcecb3f133470844e02e33e Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 44cd624a4b8c626fb5444199c06b5e05675c3cc1 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org