[dpdk-stable] patch 'ethdev: avoid blocking telemetry for link status' has been queued to stable release 20.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Fri Feb 5 12:17:32 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/7cef99775d947c9b34c5d62df62374e3cdf2fc0d

Thanks.

Luca Boccassi

---
>From 7cef99775d947c9b34c5d62df62374e3cdf2fc0d Mon Sep 17 00:00:00 2001
From: Bruce Richardson <bruce.richardson at intel.com>
Date: Thu, 14 Jan 2021 12:17:33 +0000
Subject: [PATCH] ethdev: avoid blocking telemetry for link status

[ upstream commit 26fe208ad81fc7439728d743bccd4b2a32701bfe ]

When querying the link status via telemetry interface, we don't want the
client to have to wait for multiple seconds for a reply. Therefore use
"rte_eth_link_get_nowait()" rather than "rte_eth_link_get()" in the
telemetry callback.

Fixes: c190daedb9b1 ("ethdev: add telemetry callbacks")

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
Acked-by: Ciara Power <ciara.power at intel.com>
Acked-by: Thomas Monjalon <thomas at monjalon.net>
---
 lib/librte_ethdev/rte_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c
index 71e1e9a6db..8c584e4c83 100644
--- a/lib/librte_ethdev/rte_ethdev.c
+++ b/lib/librte_ethdev/rte_ethdev.c
@@ -5711,7 +5711,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused,
 	if (!rte_eth_dev_is_valid_port(port_id))
 		return -1;
 
-	ret = rte_eth_link_get(port_id, &link);
+	ret = rte_eth_link_get_nowait(port_id, &link);
 	if (ret < 0)
 		return -1;
 
-- 
2.29.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-02-05 11:18:36.700173021 +0000
+++ 0166-ethdev-avoid-blocking-telemetry-for-link-status.patch	2021-02-05 11:18:29.122697128 +0000
@@ -1 +1 @@
-From 26fe208ad81fc7439728d743bccd4b2a32701bfe Mon Sep 17 00:00:00 2001
+From 7cef99775d947c9b34c5d62df62374e3cdf2fc0d Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 26fe208ad81fc7439728d743bccd4b2a32701bfe ]
+
@@ -12 +13,0 @@
-Cc: stable at dpdk.org
@@ -22 +23 @@
-index 9fe1c9d769..daf5f24f7e 100644
+index 71e1e9a6db..8c584e4c83 100644
@@ -25 +26 @@
-@@ -5739,7 +5739,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused,
+@@ -5711,7 +5711,7 @@ eth_dev_handle_port_link_status(const char *cmd __rte_unused,


More information about the stable mailing list