[dpdk-stable] patch 'examples/pipeline: fix CLI parsing crash' has been queued to stable release 20.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Fri Feb 5 12:18:12 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/70f2333c51d6042541fa233ff2693cf7472c5693

Thanks.

Luca Boccassi

---
>From 70f2333c51d6042541fa233ff2693cf7472c5693 Mon Sep 17 00:00:00 2001
From: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
Date: Thu, 28 Jan 2021 19:12:39 +0000
Subject: [PATCH] examples/pipeline: fix CLI parsing crash

[ upstream commit 821848f5192c6b6be954fa9f04c0e6a470cff2b6 ]

Cannot dereference pointer for token[1] unless valid.

Fixes: 5074e1d551 ("examples/pipeline: add configuration commands")

Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 examples/pipeline/cli.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/pipeline/cli.c b/examples/pipeline/cli.c
index d0150cfcf6..e97e120606 100644
--- a/examples/pipeline/cli.c
+++ b/examples/pipeline/cli.c
@@ -1294,7 +1294,7 @@ cli_process(char *in, char *out, size_t out_size, void *obj)
 	}
 
 	if (strcmp(tokens[0], "link") == 0) {
-		if (strcmp(tokens[1], "show") == 0) {
+		if ((n_tokens >= 2) && (strcmp(tokens[1], "show") == 0)) {
 			cmd_link_show(tokens, n_tokens, out, out_size, obj);
 			return;
 		}
-- 
2.29.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-02-05 11:18:38.343283840 +0000
+++ 0206-examples-pipeline-fix-CLI-parsing-crash.patch	2021-02-05 11:18:29.166697965 +0000
@@ -1 +1 @@
-From 821848f5192c6b6be954fa9f04c0e6a470cff2b6 Mon Sep 17 00:00:00 2001
+From 70f2333c51d6042541fa233ff2693cf7472c5693 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 821848f5192c6b6be954fa9f04c0e6a470cff2b6 ]
+
@@ -9 +10,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list