[dpdk-stable] patch 'app/testpmd: fix queue reconfig request on Rx split update' has been queued to stable release 20.11.1

luca.boccassi at gmail.com luca.boccassi at gmail.com
Fri Feb 5 12:19:20 CET 2021


Hi,

FYI, your patch has been queued to stable release 20.11.1

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 02/07/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/61593e139ef88379decb94fb18a9fd4c4ebaae0a

Thanks.

Luca Boccassi

---
>From 61593e139ef88379decb94fb18a9fd4c4ebaae0a Mon Sep 17 00:00:00 2001
From: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
Date: Thu, 21 Jan 2021 12:46:33 +0000
Subject: [PATCH] app/testpmd: fix queue reconfig request on Rx split update

[ upstream commit 293ca0aaafaaed4b0ff96f5fec30fbd54f8e9cb3 ]

There is the "set rxpkts" command in the testpmd interactive mode,
it configures the segment sizes to split the packet on receiving.
The mentioned segment sizes are provided on the Rx queue setup
as part of queue configuration. Hence, to take the rxpkts command
into effect the Rx queues must be explicitly reconfigured.

The explained above is related to the "set rxoffs" as well.

The patch sets the queue reconfiguration request flag for
all devices once Rx split settings are updated, to take
the changes into effect the port(s) should be restarted.

Fixes: 0f2096d7ab36 ("app/testpmd: add rxpkts commands and parameters")
Fixes: 91c78e090eed ("app/testpmd: add rxoffs commands and parameters")

Signed-off-by: Viacheslav Ovsiienko <viacheslavo at nvidia.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit at intel.com>
---
 app/test-pmd/cmdline.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 5436cfbd7d..2b9dd3e1f4 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3789,6 +3789,7 @@ cmd_set_rxoffs_parsed(void *parsed_result,
 				  MAX_SEGS_BUFFER_SPLIT, seg_offsets, 0);
 	if (nb_segs > 0)
 		set_rx_pkt_offsets(seg_offsets, nb_segs);
+	cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1);
 }
 
 cmdline_parse_token_string_t cmd_set_rxoffs_keyword =
@@ -3835,6 +3836,7 @@ cmd_set_rxpkts_parsed(void *parsed_result,
 				  MAX_SEGS_BUFFER_SPLIT, seg_lengths, 0);
 	if (nb_segs > 0)
 		set_rx_pkt_segments(seg_lengths, nb_segs);
+	cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1);
 }
 
 cmdline_parse_token_string_t cmd_set_rxpkts_keyword =
-- 
2.29.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-02-05 11:18:41.259420898 +0000
+++ 0274-app-testpmd-fix-queue-reconfig-request-on-Rx-split-u.patch	2021-02-05 11:18:29.378702002 +0000
@@ -1 +1 @@
-From 293ca0aaafaaed4b0ff96f5fec30fbd54f8e9cb3 Mon Sep 17 00:00:00 2001
+From 61593e139ef88379decb94fb18a9fd4c4ebaae0a Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 293ca0aaafaaed4b0ff96f5fec30fbd54f8e9cb3 ]
+
@@ -20 +21,0 @@
-Cc: stable at dpdk.org
@@ -29 +30 @@
-index 789f35f099..59722d268b 100644
+index 5436cfbd7d..2b9dd3e1f4 100644
@@ -32 +33 @@
-@@ -3791,6 +3791,7 @@ cmd_set_rxoffs_parsed(void *parsed_result,
+@@ -3789,6 +3789,7 @@ cmd_set_rxoffs_parsed(void *parsed_result,
@@ -40 +41 @@
-@@ -3837,6 +3838,7 @@ cmd_set_rxpkts_parsed(void *parsed_result,
+@@ -3835,6 +3836,7 @@ cmd_set_rxpkts_parsed(void *parsed_result,


More information about the stable mailing list