[dpdk-stable] [PATCH v2 2/5] net/hns3: fix build with sve enabled
Honnappa Nagarahalli
Honnappa.Nagarahalli at arm.com
Sat Jan 9 01:06:28 CET 2021
<snip>
>
> Building with SVE extension enabled stopped with error:
>
> error: ACLE function ‘svwhilelt_b64_s32’ requires ISA extension ‘sve’
> 18 | #define PG64_256BIT svwhilelt_b64(0, 4)
>
> This is caused by unintentional cflags reset.
> Fixed the issue by appending required flag to cflags instead of overriding it.
>
> Fixes: 952ebacce4f2 ("net/hns3: support SVE Rx")
> Cc: xavier.huwei at huawei.com
> Cc: stable at dpdk.org
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang at arm.com>
> ---
> drivers/net/hns3/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build
> index 45cee34d9..798086357 100644
> --- a/drivers/net/hns3/meson.build
> +++ b/drivers/net/hns3/meson.build
> @@ -32,7 +32,7 @@ deps += ['hash']
> if arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')
> sources += files('hns3_rxtx_vec.c')
> if cc.get_define('__ARM_FEATURE_SVE', args: machine_args) != ''
> - cflags = ['-DCC_SVE_SUPPORT']
> + cflags += ['-DCC_SVE_SUPPORT']
This comment is unrelated to this patch. We need to be consistent with the macro definitions. Is '__ARM_FEATURE_SVE' not enough? If we need to define an additional flag, I would name it something like 'RTE_ARM_FEATURE_SVE'.
> sources += files('hns3_rxtx_vec_sve.c')
> endif
> endif
> --
> 2.25.1
More information about the stable
mailing list