[dpdk-stable] [PATCH] build: provide suitable error for "both" libraries option

Bruce Richardson bruce.richardson at intel.com
Mon Jan 11 14:55:59 CET 2021


Rather than having the DPDK configuration error out when linking apps
and examples when "both" is select for "default_library" option, we can
detect that setting earlier in the build config and provide a suitable
error message to the user.

CC: stable at dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
---
 config/meson.build | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/config/meson.build b/config/meson.build
index 3ddcc3539..05e9cede5 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -308,3 +308,12 @@ if get_option('b_lto')
 		add_project_link_arguments('-Wno-lto-type-mismatch', language: 'c')
 	endif
 endif
+
+if get_option('default_library') == 'both'
+	error( '''
+    Unsupported value "both" for "default_library" option.
+
+    NOTE: DPDK always builds both shared and static libraries.  Please set
+    "default_library" to either "static" or "shared" to select default linkage
+    for apps and any examples''')
+endif
--
2.27.0



More information about the stable mailing list