[dpdk-stable] [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

[Yu, DapengX]

Hi Beilei,

Thanks for your comments, I will prepare patch v2.

-----Original Message-----
From: Xing, Beilei 
Sent: Friday, January 15, 2021 1:50 PM
To: Yu, DapengX <dapengx.yu at intel.com>; Lu, Wenzhuo <wenzhuo.lu at intel.com>; Iremonger, Bernard <bernard.iremonger at intel.com>
Cc: Stephen Hemminger <stephen at networkplumber.org>; dev at dpdk.org; stable at dpdk.org
Subject: RE: [dpdk-dev] [PATCH] app/testpmd: avoid exit without resource release

> -----Original Message-----
> From: Yu, DapengX <dapengx.yu at intel.com>
> Sent: Friday, January 15, 2021 11:29 AM
> To: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Xing, Beilei 
> <beilei.xing at intel.com>; Iremonger, Bernard 
> <bernard.iremonger at intel.com>
> Cc: Yu, DapengX <dapengx.yu at intel.com>; Stephen Hemminger 
> <stephen at networkplumber.org>; dev at dpdk.org; stable at dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: avoid exit without 
> resource release
> 
> Hi Wenzhuo, Beilei, Bernard
> 
> I need testpmd app maintainers' comment :
>     Do you prefer the simple solution in this patch or Stephen's 
> comprehensive and generic solution(which will modify librte_cmdline, 
> testpmd (and maybe rte_exit()))?

The patch just workarounds a specific case, the issue exits in many cases, such as Rxonly mode and Rxq is 0.
So It's better to investigate how to solve the generic problem according to Stephen's comments.

> So I can continue resolving the defect.
> 
> Thanks!
> 
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yu, DapengX
> Sent: Friday, December 25, 2020 1:09 PM
> To: Stephen Hemminger <stephen at networkplumber.org>
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Xing, Beilei 
> <beilei.xing at intel.com>; Iremonger, Bernard 
> <bernard.iremonger at intel.com>; dev at dpdk.org; stable at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without 
> resource release
> 
> Hi Stephen,
> 
> Do you mean this solution?
> 1. support atexit() in librte_eal, other component can use it to 
> register a function to be called when rte_exit() is called.
> 2. in librte_cmdline, use atexit() to register a function to release 
> resource
> 
> I am looking forward to more comments from other maintainers, since 
> this solution will modify librte_eal and librte_cmdline, but not just testpmd app.
> 
> 
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen at networkplumber.org]
> Sent: Friday, December 25, 2020 11:03 AM
> To: Yu, DapengX <dapengx.yu at intel.com>
> Cc: Lu, Wenzhuo <wenzhuo.lu at intel.com>; Xing, Beilei 
> <beilei.xing at intel.com>; Iremonger, Bernard 
> <bernard.iremonger at intel.com>; dev at dpdk.org; stable at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: avoid exit without 
> resource release
> 
> On Thu, 24 Dec 2020 11:57:48 +0800
> dapengx.yu at intel.com wrote:
> 
> > From: YU DAPENG <dapengx.yu at intel.com>
> >
> > In interactive mode, if testpmd exit by calling rte_exit without 
> > cmdline resource release, terminal will not echo keyboard input. So 
> > add code to just show error message, but not exit testpmd when 
> > unexpected happens on starting packet forwarding in interactive 
> > mode. User
> can type "quit"
> > to exit testpmd later.
> >
> > Fixes: 5a8fb55c48ab ("app/testpmd: support unidirectional
> > configuration")
> > Cc: stable at dpdk.org
> >
> > Signed-off-by: YU DAPENG <dapengx.yu at intel.com>
> 
> Sounds like a more generic problem with rte_exit and librte_cmdline.
> Would it better to fix it in librte_cmdline by adding an atexit() handler.
>