[dpdk-stable] [PATCH] net/ice: fix memzone leak when firmware is missing

[Wang, Haiyue]

> -----Original Message-----
> From: David Marchand <david.marchand at redhat.com>
> Sent: Tuesday, July 6, 2021 21:28
> To: Wang, Haiyue <haiyue.wang at intel.com>
> Cc: dev at dpdk.org; stable at dpdk.org; Yang, Qiming <qiming.yang at intel.com>; Zhang, Qi Z
> <qi.z.zhang at intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr at intel.com>
> Subject: Re: [PATCH] net/ice: fix memzone leak when firmware is missing
> 
> On Tue, Jul 6, 2021 at 2:53 PM Wang, Haiyue <haiyue.wang at intel.com> wrote:
> > > > The function 'ice_deinit_hw' should be used. ;-)
> > > >
> > > >
> > >
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/ethernet/intel/ice
> > > /ice_main.c#n4508
> > >
> > > Well I was inspired by ice_dev_close(), so I guess this code too could
> > > use some cleanup but I don't have the hw anymore to test this change.
> > > I'll trust you and simply update ice_dev_init.
> 
> Adding to this, there are other potential leaks if ice_flow_init() or
> ice_reset_fxp_resource() fails.
> Probably worth opening a bz for later processing.
> WDYT?

Yeah, make sense. ;-)

> 
> 
> --
> David Marchand