[dpdk-stable] patch 'tests/eal: fix memory leak' has been queued to stable release 20.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Jul 12 15:04:31 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/451ead3bfd8358667c6d8c19e6c003c7027a80eb

Thanks.

Luca Boccassi

---
>From 451ead3bfd8358667c6d8c19e6c003c7027a80eb Mon Sep 17 00:00:00 2001
From: Owen Hilyard <ohilyard at iol.unh.edu>
Date: Wed, 16 Jun 2021 12:24:52 -0400
Subject: [PATCH] tests/eal: fix memory leak

[ upstream commit 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b ]

The directory steam was not closed when the hugepage action was
HUGEPAGE_CHECK_EXISTS. This caused a memory leak in some parts of
the unit tests.

Fixes: 45f1b6e8680a ("app: add new tests on eal flags")

Signed-off-by: Owen Hilyard <ohilyard at iol.unh.edu>
Reviewed-by: David Marchand <david.marchand at redhat.com>
---
 app/test/test_eal_flags.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c
index 932fbe3d08..b4880ee802 100644
--- a/app/test/test_eal_flags.c
+++ b/app/test/test_eal_flags.c
@@ -124,6 +124,7 @@ process_hugefiles(const char * prefix, enum hugepage_action action)
 			case HUGEPAGE_CHECK_EXISTS:
 				{
 					/* file exists, return */
+					closedir(hugepage_dir);
 					result = 1;
 					goto end;
 				}
-- 
2.30.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-07-12 13:41:38.559588607 +0100
+++ 0036-tests-eal-fix-memory-leak.patch	2021-07-12 13:41:36.298118611 +0100
@@ -1 +1 @@
-From 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b Mon Sep 17 00:00:00 2001
+From 451ead3bfd8358667c6d8c19e6c003c7027a80eb Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 80731e4b5b44036d05ae9b36432b6f2fd9f49d3b ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list