[dpdk-stable] patch 'table: fix bucket empty check' has been queued to stable release 20.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Jul 12 15:05:51 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/14/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/ff85ab73c14ce6409ef53530f45ad6747d26d132

Thanks.

Luca Boccassi

---
>From ff85ab73c14ce6409ef53530f45ad6747d26d132 Mon Sep 17 00:00:00 2001
From: Thierry Herbelot <thierry.herbelot at 6wind.com>
Date: Wed, 7 Jul 2021 13:19:05 +0200
Subject: [PATCH] table: fix bucket empty check

[ upstream commit 3fc2ddffde95478b65d8b58df5210293e63c00ee ]

Due to a typo, only 3 out of 4 keys in the bucket of the exact match
table were considered, which can result in valid keys being
incorrectly dropped from the table.

Fixes: d0a00966618ba ("table: add exact match SWX table")

Signed-off-by: Thierry Herbelot <thierry.herbelot at 6wind.com>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu at intel.com>
---
 lib/librte_table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_table/rte_swx_table_em.c b/lib/librte_table/rte_swx_table_em.c
index 788e25f6b9..03b28c4c9d 100644
--- a/lib/librte_table/rte_swx_table_em.c
+++ b/lib/librte_table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ?
 		1 : 0;
 }
 
-- 
2.30.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-07-12 13:41:42.604946488 +0100
+++ 0116-table-fix-bucket-empty-check.patch	2021-07-12 13:41:36.934131859 +0100
@@ -1 +1 @@
-From 3fc2ddffde95478b65d8b58df5210293e63c00ee Mon Sep 17 00:00:00 2001
+From ff85ab73c14ce6409ef53530f45ad6747d26d132 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 3fc2ddffde95478b65d8b58df5210293e63c00ee ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org
@@ -16 +17 @@
- lib/table/rte_swx_table_em.c | 2 +-
+ lib/librte_table/rte_swx_table_em.c | 2 +-
@@ -19 +20 @@
-diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
+diff --git a/lib/librte_table/rte_swx_table_em.c b/lib/librte_table/rte_swx_table_em.c
@@ -21,2 +22,2 @@
---- a/lib/table/rte_swx_table_em.c
-+++ b/lib/table/rte_swx_table_em.c
+--- a/lib/librte_table/rte_swx_table_em.c
++++ b/lib/librte_table/rte_swx_table_em.c


More information about the stable mailing list