[dpdk-stable] [PATCH v2] net/bnxt: fix missing barriers in completion handling

Ajit Khaparde ajit.khaparde at broadcom.com
Mon Jul 12 23:43:50 CEST 2021


On Sun, Jul 11, 2021 at 7:34 PM Ruifeng Wang <Ruifeng.Wang at arm.com> wrote:

> > -----Original Message-----
> > From: Lance Richardson <lance.richardson at broadcom.com>
> > Sent: Saturday, July 10, 2021 12:39 AM
> > To: Ajit Khaparde (ajit.khaparde at broadcom.com)
> > <ajit.khaparde at broadcom.com>; Somnath Kotur
> > <somnath.kotur at broadcom.com>; Bruce Richardson
> > <bruce.richardson at intel.com>; Konstantin Ananyev
> > <konstantin.ananyev at intel.com>; jerinj at marvell.com; Ruifeng Wang
> > <Ruifeng.Wang at arm.com>; Stephen Hurd <stephen.hurd at broadcom.com>;
> > David Christensen <david.christensen at broadcom.com>
> > Cc: dev at dpdk.org; stable at dpdk.org
> > Subject: [PATCH v2] net/bnxt: fix missing barriers in completion handling
> >
> > Ensure that Rx/Tx/Async completion entry fields are accessed
> > only after the completion's valid flag has been loaded and
> > verified. This is needed for correct operation on systems that
> > use relaxed memory consistency models.
> >
> > Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code")
> > Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
> > Cc: stable at dpdk.org
> > Signed-off-by: Lance Richardson <lance.richardson at broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
> > ---
> > v2:
> > * Corrected name of the first parameter to bnxt_cpr_cmp_valid() in
> >   comments ('cmp' to 'cmpl').
> >
> >  drivers/net/bnxt/bnxt_cpr.h           | 36 ++++++++++++++++++++++++---
> >  drivers/net/bnxt/bnxt_ethdev.c        | 16 ++++++------
> >  drivers/net/bnxt/bnxt_irq.c           |  7 +++---
> >  drivers/net/bnxt/bnxt_rxr.c           |  9 ++++---
> >  drivers/net/bnxt/bnxt_rxtx_vec_avx2.c |  2 +-
> >  drivers/net/bnxt/bnxt_rxtx_vec_neon.c |  2 +-
> >  drivers/net/bnxt/bnxt_rxtx_vec_sse.c  |  2 +-
> >  drivers/net/bnxt/bnxt_txr.c           |  2 +-
> >  8 files changed, 54 insertions(+), 22 deletions(-)
> >
> Reviewed-by: Ruifeng Wang <ruifeng.wang at arm.com>
>
Patch applied to dpdk-next-net-brcm. Thanks


More information about the stable mailing list