[dpdk-stable] [PATCH v4] telemetry: fix race in telemetry control thread creation

Kevin Traynor ktraynor at redhat.com
Tue Jul 13 15:44:37 CEST 2021


On 13/07/2021 14:31, Power, Ciara wrote:
> Hi Alvin,
> 
>> -----Original Message-----
>> From: Zhang, AlvinX <alvinx.zhang at intel.com>
>> Sent: Tuesday 13 July 2021 07:42
>> To: christian.ehrhardt at canonical.com; Chen, LingliX <linglix.chen at intel.com>;
>> Jiang, YuX <yux.jiang at intel.com>; Power, Ciara <ciara.power at intel.com>; Van
>> Haaren, Harry <harry.van.haaren at intel.com>
>> Cc: Zhang, AlvinX <alvinx.zhang at intel.com>; stable at dpdk.org
>> Subject: [PATCH v4] telemetry: fix race in telemetry control thread creation
>>
>> Before the caller returns from function "rte_ctrl_thread_create", the newly
>> created thread may have ran, and because the thread control flag was not set
>> before, the new thread may exit soon.
>> This is not what the developer expected.
>>
>> This patch puts the setting thread control flag to the place that before creating
>> new thread.
>>
>> Reported-at: https://bugs.dpdk.org/show_bug.cgi?id=731
>> Fixes: 8877ac688b52 ("telemetry: introduce infrastructure")
>> Cc: stable at dpdk.org
>>
>> Signed-off-by: Alvin Zhang <alvinx.zhang at intel.com>
>> ---
>>
> <snip>
> 
> Thanks for this, I guess it is targeted towards both 18.11 and 19.11 stable releases?

18.11 LTS is no longer maintained, so it would just be a candidate for
19.11 but I guess that was the intent looking at the Bz.

> This file was removed in 20.11 so won't be needed there.
> 
> Acked-by: Ciara Power <ciara.power at intel.com>
> 
> 



More information about the stable mailing list