[dpdk-stable] patch 'net/softnic: fix connection memory leak' has been queued to stable release 20.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Jul 26 15:52:26 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/96ad1e25fc0265ec2b5776af7833f0beb25bb18f

Thanks.

Luca Boccassi

---
>From 96ad1e25fc0265ec2b5776af7833f0beb25bb18f Mon Sep 17 00:00:00 2001
From: Dapeng Yu <dapengx.yu at intel.com>
Date: Fri, 9 Jul 2021 14:00:56 +0800
Subject: [PATCH] net/softnic: fix connection memory leak

[ upstream commit ae2b3ba6430d9f86cc3583b893f442aaa8934655 ]

In function softnic_conn_init(), a block of memory is allocated as
connection buffer, but it is never freed in softnic_conn_free(),
which cause memory leak.

Fixes: 7709a63bf178 ("net/softnic: add connection agent")

Signed-off-by: Dapeng Yu <dapengx.yu at intel.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko at oktetlabs.ru>
---
 drivers/net/softnic/conn.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/softnic/conn.c b/drivers/net/softnic/conn.c
index 8b66580887..5b031358d5 100644
--- a/drivers/net/softnic/conn.c
+++ b/drivers/net/softnic/conn.c
@@ -144,6 +144,7 @@ softnic_conn_free(struct softnic_conn *conn)
 
 	free(conn->msg_out);
 	free(conn->msg_in);
+	free(conn->buf);
 	free(conn->prompt);
 	free(conn->welcome);
 	free(conn);
-- 
2.30.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-07-26 13:53:16.126777061 +0100
+++ 0003-net-softnic-fix-connection-memory-leak.patch	2021-07-26 13:53:15.769290941 +0100
@@ -1 +1 @@
-From ae2b3ba6430d9f86cc3583b893f442aaa8934655 Mon Sep 17 00:00:00 2001
+From 96ad1e25fc0265ec2b5776af7833f0beb25bb18f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit ae2b3ba6430d9f86cc3583b893f442aaa8934655 ]
+
@@ -11 +12,0 @@
-Cc: stable at dpdk.org


More information about the stable mailing list