[dpdk-stable] patch 'raw/ioat: fix config script queue size calculation' has been queued to stable release 20.11.3

luca.boccassi at gmail.com luca.boccassi at gmail.com
Mon Jul 26 15:52:40 CEST 2021


Hi,

FYI, your patch has been queued to stable release 20.11.3

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/21. So please
shout if anyone has objections.

Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.

Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable

This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/1f4a450852e4800fb4c1faa610fdea441c02dc05

Thanks.

Luca Boccassi

---
>From 1f4a450852e4800fb4c1faa610fdea441c02dc05 Mon Sep 17 00:00:00 2001
From: Kevin Laatz <kevin.laatz at intel.com>
Date: Fri, 16 Jul 2021 13:21:55 +0000
Subject: [PATCH] raw/ioat: fix config script queue size calculation

[ upstream commit 9cf9ac48b116e371e25e1daca33636e9cdc07db8 ]

The queue size calculation is currently based on "max_tokens" rather than
"max_work_queues_size". This is resulting in the queue size being
incorrectly configured when using the script to configure devices bound to
the IDXD kernel driver.
This patch fixes this miscalculation so devices are configured with
appropriate queue size.

Fixes: 01863b9d2354 ("raw/ioat: include example configuration script")

Reported-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
Signed-off-by: Kevin Laatz <kevin.laatz at intel.com>
Acked-by: Konstantin Ananyev <konstantin.ananyev at intel.com>
Acked-by: Bruce Richardson <bruce.richardson at intel.com>
---
 drivers/raw/ioat/dpdk_idxd_cfg.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/raw/ioat/dpdk_idxd_cfg.py b/drivers/raw/ioat/dpdk_idxd_cfg.py
index 56e44063e4..fdb636498c 100755
--- a/drivers/raw/ioat/dpdk_idxd_cfg.py
+++ b/drivers/raw/ioat/dpdk_idxd_cfg.py
@@ -37,7 +37,7 @@ def configure_dsa(dsa_id, queues):
     max_groups = dsa_dir.read_int("max_groups")
     max_engines = dsa_dir.read_int("max_engines")
     max_queues = dsa_dir.read_int("max_work_queues")
-    max_tokens = dsa_dir.read_int("max_tokens")
+    max_work_queues_size = dsa_dir.read_int("max_work_queues_size")
 
     nb_queues = min(queues, max_queues)
     if queues > nb_queues:
@@ -56,7 +56,7 @@ def configure_dsa(dsa_id, queues):
                              "mode": "dedicated",
                              "name": f"dpdk_wq{dsa_id}.{q}",
                              "priority": 1,
-                             "size": int(max_tokens / nb_queues)})
+                             "size": int(max_work_queues_size / nb_queues)})
 
     # enable device and then queues
     drv_dir.write_values({"bind": f"dsa{dsa_id}"})
-- 
2.30.2

---
  Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- -	2021-07-26 13:53:16.780509559 +0100
+++ 0017-raw-ioat-fix-config-script-queue-size-calculation.patch	2021-07-26 13:53:15.833292286 +0100
@@ -1 +1 @@
-From 9cf9ac48b116e371e25e1daca33636e9cdc07db8 Mon Sep 17 00:00:00 2001
+From 1f4a450852e4800fb4c1faa610fdea441c02dc05 Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 9cf9ac48b116e371e25e1daca33636e9cdc07db8 ]
+
@@ -14 +15,0 @@
-Cc: stable at dpdk.org
@@ -25 +26 @@
-index 83ef4817db..fcc27822ef 100755
+index 56e44063e4..fdb636498c 100755
@@ -28 +29 @@
-@@ -63,7 +63,7 @@ def configure_dsa(dsa_id, queues, prefix):
+@@ -37,7 +37,7 @@ def configure_dsa(dsa_id, queues):
@@ -37 +38 @@
-@@ -82,7 +82,7 @@ def configure_dsa(dsa_id, queues, prefix):
+@@ -56,7 +56,7 @@ def configure_dsa(dsa_id, queues):
@@ -39 +40 @@
-                              "name": f"{prefix}_wq{dsa_id}.{q}",
+                              "name": f"dpdk_wq{dsa_id}.{q}",


More information about the stable mailing list