[dpdk-stable] [dpdk-dev] [PATCH v4] app/testpmd: fix TX checksum calculation for tunnel

[Thomas Monjalon]

30/07/2021 10:39, Olivier Matz:
> On Thu, Jul 29, 2021 at 08:01:41PM +0300, Gregory Etelson wrote:
> > csumonly engine calculates TX checksum of a tunnelled packet for outer
> > headers only or separately for outer and inner headers. The
> > calculation method is determined by checksum configuration options.
> > If TX checksum calculation is separated, the inner headers are
> > processed before outer headers.
> > 
> > Inner headers processing sets checksum values to 0 unconditionally.
> > If TX configuration offloads inner checksums only, outer checksum
> > calculation in software will read 0 instead of real values and
> > produce wrong result.
> > 
> > The patch zeroes inner checksums only before software calculation.
> > 
> > Fixes: 6b520d54ebfe ("app/testpmd: use Tx preparation in checksum engine")
> > Cc: stable at dpdk.org
> > 
> > Signed-off-by: Gregory Etelson <getelson at nvidia.com>
> 
> Acked-by: Olivier Matz <olivier.matz at 6wind.com>
> 

The previous acks were forgotten (it should be added manually in the patch):

Acked-by: Ori Kam <orika at nvidia.com>
Acked-by: Ajit Khaparde <ajit.khaparde at broadcom.com>
Acked-by: Xiaoyun Li <xiaoyun.li at intel.com>

Applied, thanks.