[dpdk-stable] [PATCH v4] bus: clarify log for non-NUMA-aware devices
Thomas Monjalon
thomas at monjalon.net
Fri Jul 30 18:18:34 CEST 2021
29/07/2021 00:06, Dmitry Kozlyuk:
> EAL: PCI device 0000:00:06.0 on NUMA socket -1
> - EAL: Invalid NUMA socket, default to 0
> + EAL: Device is not NUMA-aware, defaulting socket to 0
> EAL: probe driver: 1d0f:ec20 net_ena
The indentation in logs are wrong because they are not all
at the same log level.
If you run at a non-debug-level, you lose the first line,
so the indent becomes meaningless and confusing.
[...]
> - AUXILIARY_LOG(INFO, "Device is not NUMA-aware, defaulting NUMA node to 0");
> + if (rte_socket_count() > 1)
> + AUXILIARY_LOG(INFO, " Device is not NUMA-aware, defaulting socket to
0");
Instead of adding an indent, I would prefer we print the device name.
And we should remove log indents in other bus drivers.
More information about the stable
mailing list